cert service doesn't need identity info

G-Research · Aug 22, 2024 · ecbd4eb · ecbd4eb
1 parent 45b3195
commit ecbd4eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/lib/services/certificate_service.rb b/app/lib/services/certificate_service.rb
@@ -5,8 +5,8 @@ def initialize
       @impl = VaultService.new
     end
 
-    def get_cert_for(identity, cert_issue_request)
-      @impl.get_cert_for(identity, cert_issue_request)
+    def issue_cert(cert_issue_request)
+      @impl.issue_cert(cert_issue_request)
     end
   end
 end
diff --git a/app/lib/services/vault_service.rb b/app/lib/services/vault_service.rb
@@ -1,13 +1,14 @@
 module Services
   class VaultService
     def initialize
+      # TODO create a new token for use in the session
       @client = Vault::Client.new(
         address: Rails.application.config.astral[:vault_addr],
         token: Rails.application.config.astral[:vault_token]
       )
     end
 
-    def get_cert_for(identity, cert_issue_request)
+    def issue_cert(cert_issue_request)
       # Generate the TLS certificate using the intermediate CA
       tls_cert = @client.logical.write(Rails.application.config.astral[:vault_cert_path],
           common_name: cert_issue_request.common_name,