Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm chart #21

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Add Helm chart #21

merged 3 commits into from
Sep 9, 2024

Conversation

ljubon
Copy link
Contributor

@ljubon ljubon commented Sep 5, 2024

Action items with merging this PR:

  • Create docker environment
    • Create environment variable RUBY_VERSION with value 3.3.4
    • Create environment variable RAILS_ROOT with value /app
  • Check https://github.com/G-Research/astral/settings/actions
    • The Workflow permissions should have enabled Read and Write permissions in order to be able to push docker image to Github Container registry with GITHUB_TOKEN. If this is not acceptable or we don't have option to change this we should instead use PAT

Below you can find CLI command to test the chart and run application within k8s cluster:

# Install kind - tool to run k8s cluster inside single container required for testing helm chart and used during development
# https://kind.sigs.k8s.io/docs/user/quick-start/#installation

# Helm manifests to-be-deployed
helm template astral . -f values.yaml > debug.yaml 

kind create cluster --name astral

# Make sure that before this, image is built within CI and push 
# (development image was ghcr.io/g-research/astral:latest) 
kind load docker-image ghcr.io/g-research/astral:latest -n astral

helm install astral -f ./helm/values.yaml ./helm

kubectl logs deployment/astral

# Cleanup
helm uninstall astral
kind delete cluster --name astral

config/astral.yml Outdated Show resolved Hide resolved
helm/values.yaml Outdated Show resolved Hide resolved
* push docker image

* fix conditions

* Docker image fix:
- set id for rails user
- use ENVS in config/astral.yaml

* test docker login and push

* test docker login and push - commented out

* fix permission

* uncoment jobs

* update description
@ljubon ljubon requested a review from suprjinx September 6, 2024 08:22
Copy link
Collaborator

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@pavlovic-ivan pavlovic-ivan merged commit 785cc05 into G-Research:main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants