Add better auth error propogation from interactor to controller; plus unit test

app/controllers/certificates_controller.rb

@@ -6,9 +6,9 @@ def create
     if !req.valid?
       raise BadRequestError.new req.errors.full_messages
     end
-    result = IssueCert.call(request: req, identity: @identity)
+    result = IssueCert.call(request: req, identity: identity)
     if result.failure?
-      raise StandardError.new result.message
+      raise (result.error || StandardError.new(result.message))
     end
     @cert = result.cert
   end

app/interactors/authorize_request.rb

@@ -3,5 +3,8 @@ class AuthorizeRequest
 
   def call
     Services::DomainOwnershipService.new.authorize!(context.identity, context.request)
+  rescue AuthError => e
+    context.error = e
+    context.fail!
   end
 end

test/interactors/authorize_request_test.rb

@@ -0,0 +1,33 @@
+require "test_helper"
+
+class AuthorizeRequestTest < ActiveSupport::TestCase
+  def setup
+    @domain = domains(:group_match)
+    @identity = Identity.new(subject: @domain.owner)
+    @cr = CertIssueRequest.new(common_name: @domain.fqdn)
+    @interactor = AuthorizeRequest
+  end
+
+  test "successful call" do
+    request = CertIssueRequest.new(common_name: @domain.fqdn)
+    srv = Minitest::Mock.new
+    srv.expect :authorize!, nil, [ @identity, @cr ]
+    Services::DomainOwnershipService.stub :new, srv do
+      context = @interactor.call(identity: @identity, request: @cr)
+      assert context.success?
+    end
+  end
+
+  test "unsuccessful call" do
+    request = CertIssueRequest.new(common_name: @domain.fqdn)
+    srv = Services::DomainOwnershipService.new
+    Services::DomainOwnershipService.stub :new, srv do
+      err = ->(_, _) { raise AuthError.new "no can do" }
+      srv.stub :authorize!, err do
+        context = @interactor.call(identity: @identity, request: @cr)
+        assert_not context.success?
+        assert_kind_of AuthError, context.error
+      end
+    end
+  end
+end