Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring intermediate CA setup into the app #35

Merged
merged 41 commits into from
Sep 24, 2024
Merged

Bring intermediate CA setup into the app #35

merged 41 commits into from
Sep 24, 2024

Conversation

suprjinx
Copy link
Collaborator

Still expecting a pre-configured root, referenced by config

@suprjinx
WIP for kv support
a917c5f
@suprjinx
move models/CertIssueRequest -> lib/requests; add new request
9a24f7d
@suprjinx
Fix test which wasn't really running
094d2ae
@suprjinx
WIP for create secret
9da9d9f
@suprjinx
WIP for write and read KV
913e61b
@suprjinx
Add delete method for kv; updated README
f261fd3
@suprjinx
Fix lints
f44d438
@suprjinx
Streamline some testing bits, add destroy_secret kv support
88ce4b3
@suprjinx
Compact logging payload, rename AuthorizeRequest ->
8fbc730 
AuthorizeCertRequest for logging clarity
@suprjinx
Fix test
1e6dfe9
@suprjinx
Refactor interactors to use parent class with logging helper -- to
acaad4a 
make sure we log failures
@suprjinx
cosmetic changes
98e39b5
@suprjinx
revert rake task change
9192a7e
@suprjinx
add test for secret_request
6cd0b82
@suprjinx
get the kv engine mount from config
c69d5c3
@suprjinx
Remove bit about using dockerhub
a9abae3
@suprjinx
Log instead of puts
af2e397
@suprjinx
move intermediate CA setup from rake task to app
219787b
@suprjinx
Merge branch 'main' into ca-setup
b19ef08
@suprjinx
Fix merge error
41b8ce1
@suprjinx
Vault intermediate setup in Clients::Vault
eb77b39
@suprjinx
issue correct cert path
ae17288
@suprjinx
Fix CI
ece6f54
@suprjinx
fix lints
b87edbe
@suprjinx
uncomment
8731e61
@suprjinx
Don't need config for intermediate, it's created by the app
ce5f9d4
@suprjinx
Don't need config for kv mount, it's created by the app
394ad29
dave-gantenbein
dave-gantenbein reviewed Sep 22, 2024
View reviewed changes
app/lib/clients/vault.rb Outdated Show resolved Hide resolved
app/lib/clients/vault.rb Outdated Show resolved Hide resolved
app/lib/clients/vault.rb Show resolved Hide resolved
@suprjinx suprjinx merged commit 6958511 into G-Research:main Sep 24, 2024
2 checks passed
@suprjinx suprjinx deleted the ca-setup branch September 24, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-gantenbein dave-gantenbein dave-gantenbein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suprjinx @dave-gantenbein