Root cert setup #40
Merged
Root cert setup #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeJahad
reviewed
Sep 30, 2024
app/lib/clients/vault/certificate.rb
Outdated
| issuer_name: root_ca_ref, | ||
| ttl: "87600h").data[:certificate] | ||
| # save the root certificate | ||
| File.write("tmp/#{root_ca_ref}.crt", root_cert) |
There was a problem hiding this comment.
This doesn't seem to be used any where. I assume you are just saving it to a known location where you can find it manually if needed, right?
There was a problem hiding this comment.
yes -- i am not sure it's really needed since it can be retrieved as needed from vault -- and this does not seem to include the private key
There was a problem hiding this comment.
okay there's no private key because these are generated as internal where Vault keeps the private key and we never need to know it. Generating the cert with exported path will respond with private key as well as cert.
GeorgeJahad
reviewed
Oct 1, 2024
GeorgeJahad
reviewed
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the configuration of a root cert from rake task (developer only) to main app
Fixes #38