Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC config primitives #49
Add OIDC config primitives #49
Changes from 22 commits
e7d31cb
593126b
ad3c237
770bc42
8e999f3
3e9da0e
616e979
1903d11
806fca2
84b1638
9d55d26
6915b0e
9ff6d1f
97fdf62
20cb10d
8f6d97a
e496ef6
d33a69c
14326f0
4957347
f3a4828
3d3d1fb
5c59530
52e2420
0617b30
71a2259
289dea6
87a56aa
66c9bb1
0d6bf1c
bb90ac4
a5dfa94
3897835
9a49426
9bf5124
a733396
2a90392
56b6f76
52122d0
2793425
609cbcf
a43272f
0772fdd
3402488
a474cbd
4f7d5d3
2aba8fb
7456b02
3774510
caeb603
ed18d74
bbb3255
5c5f3c5
ca256c8
70329c3
de43ef3
8f195ca
a87e951
6b866af
7ae52ba
5e0eda0
350d286
dc4ece1
879b0db
2f35777
909516e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configured at start up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should separate the "configure as provider" and "configure as client" as distinct module files? just for conceptual clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or adding "as" in the method names -- in this case we are not configuring Vault's oidc provider but setting up vault as a provider; in the other methods we are configuring Vault's oidc provider ("_as_client")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a good idea. I'll separate out the modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conventionally i think these go at the top of the module definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this static string what you want here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to config param in astral.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice that the test is so easy, after all the hard setup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to be clear, the real test is to use "vault login -method=oidc" and then interact with the browser, as I describe in the readme, but I didn't want to force the browser interaction on the rails test.