Kv policy verification #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interactor unit test
GeorgeJahad
reviewed
Nov 5, 2024
| policies.append(policy_name).uniq! | ||
| put_entity(sub, policies, metadata) | ||
| put_entity_alias(sub, email, "oidc") | ||
| Domain.with_advisory_lock(sub) do |
There was a problem hiding this comment.
it is unfortunate that this mechanism isn't provided by vault itself, because this won't prevent another user/app from modifying the entity directly
There was a problem hiding this comment.
out of curiosity, why not just use a ruby mutex: https://ruby-doc.org/core-2.5.1/Mutex.html
There was a problem hiding this comment.
i tried! but there are apparently multiple instances of the server running, which won't share the mutex attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #70
Fixes #56