Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic bridge endpoint #34

Merged
merged 104 commits into from
Oct 28, 2024
Merged

Dynamic bridge endpoint #34

merged 104 commits into from
Oct 28, 2024

Conversation

ilaydacansinkoc
Copy link
Contributor

No description provided.

jfelixh and others added 30 commits March 15, 2024 23:12
@jfelixh
Basic Implementation of Policy Constraints
b048558 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh @actions-user
Basic Implementation of Policy Constraints
76df29d 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Merge branch 'feature_policy_conditions' of https://github.com/GAIA-X…
d1f13f9 
…4PLC-AAD/ssi-to-oidc-bridge into feature_policy_conditions
@jfelixh
Build fix
aca8efe 
Signed-off-by: Felix Hoops <[email protected]>
@ilaydacansinkoc
Add new API endpoints for authentication response and test requests
768e9d5
@ilaydacansinkoc
revert: delete unused API endpoints for authentication response and t…
f4d23d5 
…est requests
@jfelixh
OIDC Discovery Fix
48de0dc 
Fixes issue #20

Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Changed default token
3a7a298 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh @actions-user
Changed default token
0a5deba 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Update extractClaims.test.js
22d6cd1
@jfelixh @actions-user
Update extractClaims.test.js
2f4cc92
@jfelixh
Merge branch 'feature_policy_conditions' of https://github.com/GAIA-X…
7971ea4 
…4PLC-AAD/ssi-to-oidc-bridge into feature_policy_conditions
@jfelixh
Adopted absolute imports
465ae3c 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh @actions-user
Adopted absolute imports
9325e78 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Merge branch 'feature_policy_conditions' of https://github.com/GAIA-X…
016eed3 
…4PLC-AAD/ssi-to-oidc-bridge into feature_policy_conditions
@jfelixh @actions-user
Merge branch 'feature_policy_conditions' of https://github.com/GAIA-X…
bc6ac56 
…4PLC-AAD/ssi-to-oidc-bridge into feature_policy_conditions
@jfelixh
Merge branch 'feature_policy_conditions' of https://github.com/GAIA-X…
e870782 
…4PLC-AAD/ssi-to-oidc-bridge into feature_policy_conditions
@jfelixh
Fix missing styles source
aa0ac0f 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Readme disclaimer
7287aa6 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Less Hydra logs
a7d8579 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Logging improvements with pino
aa12eb9 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Text fixes
dd5eea3 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh @actions-user
Text fixes
a8b1d02 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Merge branch 'feature_policy_conditions' of https://github.com/GAIA-X…
46e4a7f 
…4PLC-AAD/ssi-to-oidc-bridge into feature_policy_conditions
@ilaydacansinkoc
add initial dynamic enpoint logic
1acabb3 
Signed-off-by: Ilayda Cansin Koc <[email protected]>
@ilaydacansinkoc
fix: move files to dynamic folder
db3d302 
Signed-off-by: Ilayda Cansin Koc <[email protected]>
@ilaydacansinkoc
enable parametric policy from sp
ad208dc 
Signed-off-by: Ilayda Cansin Koc <[email protected]>
@ilaydacansinkoc
fix: define types for input descriptor and presentation definition
39307f5 
Signed-off-by: Ilayda Cansin Koc <[email protected]>
@ilaydacansinkoc
add verifiable id descriptor
5838a46 
Signed-off-by: Ilayda Cansin Koc <[email protected]>
@ilaydacansinkoc
add logic to parametrically use input descriptor for each incr auth
a874fdd 
Signed-off-by: Ilayda Cansin Koc <[email protected]>
@jfelixh jfelixh self-assigned this Aug 7, 2024
jfelixh
jfelixh requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@jfelixh jfelixh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, lots of good changes. But there are a couple of things I am not super happy about. Would love to get some input on my comments @ilaydacansinkoc, but no code changes required. I will do whatever changes after hearing your thoughts.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vclogin/lib/generatePresentationDefinition.ts Outdated Show resolved Hide resolved
vclogin/lib/generatePresentationDefinition.ts Outdated Show resolved Hide resolved
vclogin/lib/extractClaims.ts Outdated Show resolved Hide resolved
vclogin/pages/api/clientMetadata.ts Show resolved Hide resolved
vclogin/types/LoginPolicy.ts Outdated Show resolved Hide resolved
jfelixh added 12 commits August 23, 2024 13:46
@jfelixh
fix minimal test script
3d323a5 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
package maintenance
3b3bd20 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Fix license headers
fa9045e 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Fix more license headers
8c575f1 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Add http logging middleware
68cb0b6 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Logger cleanup
7d79109 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
First API test
5a71101 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Version bump
dffdcdc 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Fixed test env loading
c39c3e6 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Fixed unit test
7772c5e 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Reverted login policy loading to be more efficient
e45c7d1 
Signed-off-by: Felix Hoops <[email protected]>
@jfelixh
Added helper to check loaded policy syntax
06b3bb7 
Signed-off-by: Felix Hoops <[email protected]>
This was linked to issues Oct 25, 2024
Operator equalsDID is not safe for every possible DID #25
Closed
Add test cases with multiple VCs in one VP #28
Closed
@jfelixh jfelixh linked an issue Oct 28, 2024 that may be closed by this pull request
Add README section about new flow option fully on mobile phone #36
Closed
@jdsika
Copy link
Contributor

jdsika commented Oct 28, 2024

Why is the build not triggered? Can you confirm the build locally?

@jfelixh
Copy link
Collaborator

jfelixh commented Oct 28, 2024

Why is the build not triggered? Can you confirm the build locally?

I have no idea. The normal build on Node 20.x works (locally and here). But the old built on 18.x, that we removed from the github action, is still showing up here. It was already removed in the last merged PR, since 18.x is pretty old and it should be sufficient to have the tests and build run on one Node version.

@jdsika jdsika merged commit 7ca5a67 into main Oct 28, 2024
4 checks passed
@jdsika jdsika deleted the dynamic_bridge_endpoint branch October 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika approved these changes

@jfelixh jfelixh jfelixh approved these changes

Assignees

@jfelixh jfelixh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@ilaydacansinkoc @jdsika @jfelixh