Allow setting of SonarQube module key bindings by applying a pattern #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nailujx86
approved these changes
Nov 18, 2024
| // create a dummy list for the purpose of collecting the number of changes only | ||
| List<String> changedModuleConfigs = new ArrayList<>(); | ||
| for (Binding binding : configuration.getBindings()) { | ||
| moduleMap.entrySet().stream().filter(e -> e.getKey().matches(binding.getModulePattern())).forEach(e -> { |
There was a problem hiding this comment.
moduleMap.entrySet().stream().filter(moduleEntry -> modukeEntry.getKey().matches(binding.getModulePattern())).forEach(moduleEntry -> {
There was a problem hiding this comment.
Descriptive lambda names are better here because not every editor displays type inferences.
| try { | ||
| return updateHandler.updateConfiguration(extensionConfiguration.get(), project); | ||
| } catch (Exception e) { | ||
| LOG.error("An error occurred trying to process configuration updates for \"{}\"", e, |
There was a problem hiding this comment.
Should the exception really be the first logger argument here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new SonarLintHandler has been added, allowing a module name pattern matching to set a SonarQube project key.
Example autoconfigSonarLint.yaml:
Closes #8