fix(restart_process): work around sticky /tmp (tilt-dev#541)

Sometimes the container root filesystem has sticky bit enabled and restart commands are ran with a different user. We can work around that by creating an intermediate folder that has "0777" permissions. Refs tilt-dev#540 Signed-off-by: db <[email protected]>
GEBIT · Jan 2, 2024 · 51a5c73 · 51a5c73
1 parent 8879d4e
commit 51a5c73
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/restart_process/Tiltfile b/restart_process/Tiltfile
@@ -1,4 +1,4 @@
-RESTART_FILE = '/tmp/.restart-proc'
+RESTART_FILE = '/tmp/.restart/proc'
 TYPE_RESTART_CONTAINER_STEP = 'live_update_restart_container_step'
 
 KWARGS_BLACKLIST = [
@@ -46,12 +46,14 @@ def _helper(base_ref, ref, entrypoint, live_update, restart_file=RESTART_FILE, t
     FROM tiltdev/restart-helper:2021-11-03 as restart-helper
 
     FROM {ref}
+    RUN ["mkdir", "-p", "{dir}"]
     RUN ["touch", "{file}"]
     RUN ["chmod", "666", "{file}"]
     COPY --from=restart-helper /tilt-restart-wrapper /
     COPY --from=restart-helper /entr /
     ENTRYPOINT {entry}
-    '''.format(ref=base_ref, file=restart_file, entry=entrypoint_with_entr)
+    '''.format(ref=base_ref, file=restart_file, dir=os.path.dirname(restart_file),
+               entry=entrypoint_with_entr)
 
     # last live_update step should always be to modify $restart_file, which
     # triggers the process wrapper to rerun $entrypoint