Loss persistence colombian forests #104
Conversation
…om/PEM-Humboldt/biab-2.0 into Loss_Persistence_Colombian_forests
Co-Authored-By: Manuel Galvez <[email protected]>
…umboldt/biab-2.0 into Loss_Persistence_Colombian_forests
…om/PEM-Humboldt/biab-2.0 into Loss_Persistence_Colombian_forests
Co-Authored-By: jmlord <[email protected]>
We update the script and yml files of loss persistence. Also we add a new collection to input folder in the same folder of script
We added an additional output to the PP script. The new output is 'PP', and it is necessary to easily load tables in Biotablero.
adicion de condicional
…la final The script has been adjusted to work properly with areas of study containing small polygons. The final output tables now include area values equal to 0 for categories not present in the study area (e.g., a polygon with only persistence will report 0 for loss and 0 for non-forest). Area values were reviewed to ensure they are in hectares. Additionally, the final table was organized according to https://docs.google.com/document/d/1omTyKjuWR1IgGeUSByU3CZwsj0Ykh45jC7e8aVb_RAc/edit.
se corrigio el orden de las dimensiones de studyarea, estaban invertidas generando conflicto
correccion etiquetas con espacio _
|
There doesn't seem to be a json pipeline file associated with this pipeline. However, there is a 01_pp.yml script file in the pipeline folder. If this hasn't been done yet, please create a pipeline using the pipeline editor, even if it has just one script in it, and copy the json content to a .json file in the pipeline folder. |
| @@ -3,3 +3,8 @@ | |||
| .Rhistory | |||
| **/.cache | |||
| **/.config | |||
| scripts/1_IAvH_functions/01_pp.R | |||
There was a problem hiding this comment.
Why adding these in gitignore? Should probably be removed from .gitignore.
There was a problem hiding this comment.
This should be removed. It's in the wrong folder, and looks like a duplicate of scripts/lossPersistance/pp.R
Same for the .yml
| @@ -0,0 +1,273 @@ | |||
| # Instalar librerias necesarias | |||
| packagesPrev<- installed.packages()[,"Package"] | |||
| packagesNeed<- list("magrittr", "terra", "raster", "sf", "fasterize", "pbapply", "gdalUtilities") | |||
There was a problem hiding this comment.
Packages fasterize and pbapply are not pre-installed. Please check if they are still necessary, and if yes add them to runners/r-dockerfile.
| @@ -0,0 +1,70 @@ | |||
| script: pp.R | |||
| description: "This sample script shows how it works." | |||
| type: int | ||
| example: 1000 | ||
| time_period: | ||
| label: time_period |
There was a problem hiding this comment.
All labels should be human-readable format. Right now they look like stake case, a duplicate of the key.
| description: "This sample script shows how it works." | ||
| external_link: https://github.com/GEO-BON/biab-2.0 | ||
| inputs: | ||
| WKT_area: |
There was a problem hiding this comment.
snake case does not allow uppercase. This should fail in the github actions.
| @@ -2,6 +2,8 @@ | |||
| server { | |||
|
|
|||
| listen 80; | |||
| client_max_body_size 8M; | |||
There was a problem hiding this comment.
I'd like a bit of background to know why this is needed. We are downloading large files from the server, but when are we uploading large files?
| @@ -2,6 +2,8 @@ | |||
| server { | |||
|
|
|||
| listen 80; | |||
| client_max_body_size 8M; | |||
| add_header Access-Control-Allow-Origin "localhost:3000"; | |||
There was a problem hiding this comment.
Please explain the situation why this is needed? A comment could be added in code to help.
If needed, conf.d-prod/nginx.conf also needs to be updated, or this will have no effect on the compiled image.
There was a problem hiding this comment.
I am not able to run the example locally, since the tiff files are missing. Could you please put the tiff files online and link to them? I see that your script supports it.
Another suggestion could be to put an external link to the files and have people download them to the userdata folder.
No description provided.