Skip to content

Commit

Permalink
Remove debugging comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bmhan12 committed Feb 22, 2024
1 parent d5adb95 commit 5abaa1a
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 21 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,9 @@ jobs:
# pygeosx testing
ENABLE_PYGEOSX=${{ inputs.ENABLE_PYGEOSX }}
echo "********************************* ENABLE_PYGEOSX: ${ENABLE_PYGEOSX}"
docker_args+=(-e ENABLE_PYGEOSX=${ENABLE_PYGEOSX:-OFF})
if [ "${{ inputs.ENABLE_PYGEOSX }}" == 'ON' ]; then
echo "******************** RUN_PYGEOSX_TESTS string ADDED"
script_args+=(--run-pygeosx-tests)
else
echo "******************** RUN_PYGEOSX_TESTS string NOT ADDED"
fi
docker_args+=(--cap-add=SYS_PTRACE --rm)
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/ci_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,21 +208,21 @@ jobs:
GCP_BUCKET: geosx/integratedTests
RUNS_ON: ubuntu-22.04

# code_coverage:
# needs:
# - is_not_draft_pull_request
# uses: ./.github/workflows/build_and_test.yml
# secrets: inherit
# with:
# BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests"
# CMAKE_BUILD_TYPE: Debug
# CODE_COVERAGE: true
# DOCKER_IMAGE_TAG: ${{ needs.is_not_draft_pull_request.outputs.DOCKER_IMAGE_TAG }}
# DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc11
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# GCP_BUCKET: geosx/ubuntu22.04-gcc11
# RUNS_ON: Runner_4core_16GB
code_coverage:
needs:
- is_not_draft_pull_request
uses: ./.github/workflows/build_and_test.yml
secrets: inherit
with:
BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests"
CMAKE_BUILD_TYPE: Debug
CODE_COVERAGE: true
DOCKER_IMAGE_TAG: ${{ needs.is_not_draft_pull_request.outputs.DOCKER_IMAGE_TAG }}
DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc11
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
GCP_BUCKET: geosx/ubuntu22.04-gcc11
RUNS_ON: Runner_4core_16GB

# If the 'ci: ready to be merged' PR label is found, the cuda jobs run immediately along side linux jobs.
# Note: CUDA jobs should only be run if PR is ready to merge.
Expand Down
2 changes: 0 additions & 2 deletions scripts/ci_build_and_test_in_container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,6 @@ if [[ "${RUN_PYGEOSX_TESTS}" = true ]]; then
or_die ninja pygeosx
or_die ninja geosx_python_tools
or_die ninja pygeosx_unit_tests
else
echo "**************************** DID NOT RUN_PYGEOSX_TESTS"
fi

if [[ "${RUN_INTEGRATED_TESTS}" = true ]]; then
Expand Down

0 comments on commit 5abaa1a

Please sign in to comment.