Bugfix/byer3/internal energy der 3053 (#3105)

GEOS-DEV · May 8, 2024 · b8cd271 · b8cd271
1 parent fec6ac2
commit b8cd271
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.integrated_tests.yaml b/.integrated_tests.yaml
@@ -1,7 +1,7 @@
 ---
 baselines:
   bucket: geosx
-  baseline: integratedTests/baseline_integratedTests-pr2917-4878-4907334
+  baseline: integratedTests/baseline_integratedTests-pr3105-4885-a1a85c1
 
 allow_fail:
   all: ''

diff --git a/BASELINE_NOTES.md b/BASELINE_NOTES.md
@@ -6,6 +6,11 @@ This file is designed to track changes to the integrated test baselines.
 Any developer who updates the baseline ID in the .integrated_tests.yaml file is expected to create an entry in this file with the pull request number, date, and their justification for rebaselining.
 These notes should be in reverse-chronological order, and use the following time format: (YYYY-MM-DD).
 
+PR #3105 (2024-05-08)
+======================
+
+Added missing derivative for temperature, hence small numerical diffs in thermal tests results and numeracal behavior
+
 
 PR #2917 (2024-05-07)
 ======================

diff --git a/src/coreComponents/constitutive/fluid/multifluid/MultiFluidBase.hpp b/src/coreComponents/constitutive/fluid/multifluid/MultiFluidBase.hpp
@@ -1047,6 +1047,7 @@ MultiFluidBase::KernelWrapper::
 {
   integer const numPhase = numPhases();
   integer const numComp = numComponents();
+  integer const numDOF = numComp + 2;
   for( integer ip = 0; ip < numPhase; ++ip )
   {
 
@@ -1059,7 +1060,7 @@ MultiFluidBase::KernelWrapper::
     real64 const densInv = 1.0 / phaseMassDens.value[ip];
     real64 const densInvSquared = densInv * densInv;
     phaseInternalEnergy.value[ip] = phaseEnthalpy.value[ip] - pressure * densInv;
-    for( integer idof = 0; idof < numComp; ++idof )
+    for( integer idof = 0; idof < numDOF; ++idof )
     {
       phaseInternalEnergy.derivs[ip][idof] = phaseEnthalpy.derivs[ip][idof] + pressure * phaseMassDens.derivs[ip][idof] * densInvSquared;
     }