Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify definition of regions in the XML #2223

Closed
jeannepellerin opened this issue Dec 20, 2022 · 3 comments · Fixed by #2878
Closed

Simplify definition of regions in the XML #2223

jeannepellerin opened this issue Dec 20, 2022 · 3 comments · Fixed by #2878
Labels

Comments

@jeannepellerin
Copy link
Contributor

What is the requested feature?
As a user, I want to define easily regions from their name in the subsurface model.

A non exhaustive list of subitems are:

  • the different cell types are managed by GEOSX
  • the user manages meaninful regions names that correspond to the subsurface model instead of an Attribute value
  • the user can create regions that do not have a physical meaning (rock type, fluid type) but e.g. border between countries

Is your request related to a specific problem?
The XML file is very complex to write and there is no check of its validity.
GEOSX might crash without notice and no error message.

Describe the solution you'd like
Check of validity of the XML
Clear error messages to the user
Replace entries that have a meaning for the developers by entries that have a meaning for the users to define Regions

@AntoineMazuyer
Copy link
Contributor

Great suggestion.

Using the VTU/VTK file there is unfortunately no way to associate an attribute id with a name... except using VTM structure BUT in my opinion, it will add complexity for users to build the mesh (need to respect a certain hierarchy, naming convention etc...).

One solution could be to provide a map attribute id <--> name that can be either communicate to geosx through an external file map.txt or in the vtu file (adding a new XML tag)

@untereiner
Copy link
Contributor

untereiner commented Jan 4, 2023

IHMO To manage meaningful regions over representations a data format more Reservoir oriented like RESQML (#2109) would be more appropriate.

@TotoGaz TotoGaz changed the title [Feature] Simplify definition of regions in the XML Simplify definition of regions in the XML Jan 12, 2023
@TotoGaz TotoGaz added type: feature New feature or request type: new A new issue has been created and requires attention labels Jan 12, 2023
@untereiner
Copy link
Contributor

If I can summarize (do not hesitate to correct me):

  • pure vtk solution:

    • With VTU files: add an attribute per region with the name of that region (add a null value to the elements not concerned by the region): memory overhead but keeps a simple format
    • With VTM files: same as above with less memory overhead but hierarchical format
  • deck oriented solution:

    • As @AntoineMazuyer wrote, add somehow a map in the deck: new file as a dependency, consistency needs to be tracked.
  • RESQML solution:

    • Already possible with SubRepresentations (flexible use and memory efficient) but puts the effort to the modelling software.

@rrsettgast rrsettgast added type: cleanup / refactor Non-functional change (NFC) changes XML input and removed type: new A new issue has been created and requires attention labels Jan 26, 2023
@TotoGaz TotoGaz removed the type: cleanup / refactor Non-functional change (NFC) label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants