-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simplification & consolidation of CellElementRegion definition #2878
Conversation
- Error when a cellBlock is referenced twice - Proper error when a referenced cellBlock is missing - Proper error when a cellBlock is not referenced - Possibility to reference all cellBlocks with "all" - Possitibility to reference all cellBlock from a region ("1" instead of "1_tetrahedra, 1_pyramids...")
…ocks-easier-naming
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2878 +/- ##
===========================================
+ Coverage 56.47% 56.79% +0.31%
===========================================
Files 1074 1076 +2
Lines 90504 95743 +5239
===========================================
+ Hits 51116 54377 +3261
- Misses 39388 41366 +1978 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that you can start working on this.
You may be interested in #1963 where we discuss how we can select objects in geos
.
...es/compositionalMultiphaseWell/benchmarks/Class09Pb3/class09_pb3_hystRelperm_direct_base.xml
Outdated
Show resolved
Hide resolved
@rrsettgast <CellElementRegion name="everything" materialList="{ }" cellBlocks="{ * }" /> <CellElementRegion name="overburden" materialList="{ }" cellBlocks="{ 1, 5 }" />
<CellElementRegion name="reservoir" materialList="{ }" cellBlocks="{ 2, 6 }" /> <CellElementRegion name="mixed" materialList="{ }"
cellBlocks="{ 1, 2_hexahedra, 2_tetrahedra, 2_pyramids, [5-6]_* }" /> <CellElementRegion name="legacy" materialList="{ }"
cellBlocks="{ 1_hexahedra, 1_tetrahedra, 1_pyramids, 5_hexahedra, 5_tetrahedra, 5_pyramids }" /> |
…ocks-easier-naming
how about this situation:
it would be nice to be able to use patterns like that:
i am sure users would appreciate |
Sure! We will add a next PR will propose this pattern feature to more fields. |
…o hdf5 outputs show the effective found names (+ some code styles + set cellBlocksNames back to required)
…ocks-easier-naming
By using a modified version of
I also changed the tag in I opened a PR to propose those changes to |
🥳 |
This PR comes after the #3247.
In order to simplify the
cellBlocks
referencing and thus simplify user workflows, this PR propose the following functionalities:cellBlock
from aregionAttribute
at once, without listing all primitives:instead of:
fnmatch
patterns:cellBlock
errors:cellBlock
is referenced twicecellBlockAttributeValues
,cellBlocks
,cellBlocksMatch
attributes are mixed (allowing only one way to selectcellblocks
).cellBlock
is missing,cellBlocks
.See the form and more details here: new cellBlocks errors.pdf (not up to date).
This PR also:
Sphinx
documentation page as it was incomplete, by providing the whole necessary python package list and a part to describe how to generate the.rst
class tables..rst
tables that were not previously pushed (forgotten?).