-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the function to update the pressure gradient in the hybrid solver #2110
Conversation
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseHybridFVM.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseHybridFVM.cpp
Outdated
Show resolved
Hide resolved
{ | ||
SinglePhaseBase::implicitStepComplete( time, dt, domain ); | ||
|
||
updatePressureGradient( domain ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you plan on merging the PR with the call to BlasLapack
in the kernel, maybe you can hard-code parallelHostPolicy
in the kernel launch and add a flag to activate/skip the execute of updatePressureGradient
from the XML file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've simply deleted updatePressureGradient
here since it will only be called after one full load step in my phase-field PR
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseHybridFVMKernels.hpp
Outdated
Show resolved
Hide resolved
* Change to StackArray * Use kernelLaunchSelectorFaceSwitch to launch the kernel for various face numbers.
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseHybridFVM.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseHybridFVMKernels.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/denseLinearAlgebra/unitTests/testBlasLapack.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/denseLinearAlgebra/unitTests/testBlasLapack.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/denseLinearAlgebra/unitTests/testBlasLapack.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/denseLinearAlgebra/unitTests/testBlasLapack.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/denseLinearAlgebra/unitTests/testBlasLapack.cpp
Outdated
Show resolved
Hide resolved
…VM.cpp Corrected policy Co-authored-by: Matteo Cusini <[email protected]>
…VMKernels.hpp Co-authored-by: Matteo Cusini <[email protected]>
….cpp Co-authored-by: Matteo Cusini <[email protected]>
….cpp Co-authored-by: Matteo Cusini <[email protected]>
….cpp Co-authored-by: Matteo Cusini <[email protected]>
….cpp Co-authored-by: Matteo Cusini <[email protected]>
….cpp Co-authored-by: Matteo Cusini <[email protected]>
…VMKernels.hpp Co-authored-by: Matteo Cusini <[email protected]>
@frankfeifan move into merge queue? |
I will have to merge the develop and rebaseline the tests, and then we can move it to merge queue. |
thanks, merge to develop is one button on github click, right? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2110 +/- ##
===========================================
- Coverage 53.58% 53.57% -0.01%
===========================================
Files 1003 1003
Lines 85189 85289 +100
===========================================
+ Hits 45645 45694 +49
- Misses 39544 39595 +51 ☔ View full report in Codecov by Sentry. |
…ulate_pressure_gradient
…m:GEOS-DEV/GEOS into feature/frank/calculate_pressure_gradient
In this PR, we have added a function in SinglePhaseHybridFVM to compute the cell-wise pressure gradient. Basically, the pressure gradient in a cell is computed according to the pressures on the cell center and all faces using a least squares method. So a routine to compute the least squares solution of a linear system is also added.