use specific implementation to get available host memory on MacOS #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herve-gross
approved these changes
Jul 24, 2023
klevzoff
reviewed
Jul 24, 2023
|
|
||
| return vmstat.free_count * pagesize; | ||
| #else | ||
| GEOS_ERROR_IF( percent > 100, "Error, percentage of memory should be smallerer than -100, check lifoOnHost (should be greater that -100)" ); |
Comment on lines
52
to
54
| // remove these definitions from mach/boolean.h that can conflict with GEOS code (eg. InputFlags::FALSE) | ||
| #undef TRUE | ||
| #undef FALSE |
There was a problem hiding this comment.
Could you instead encapsulate this implementation and all system-specific includes in a separate translation unit (.cpp)? I think LvArray/system.[h/c]pp would be a good place to expose this functionality, if you can spare the effort to open an LvArray PR.
There was a problem hiding this comment.
I'll change that, I tend to avoid commiting to LvArray as it is another project but another translation unit would be cleaner.
| * @brief Retieves current available memory on host | ||
| * @return the available memory in bytes. | ||
| */ | ||
| static inline size_t getAvailableMemory() |
There was a problem hiding this comment.
Maybe indicate in the function name that this is for host/system memory?
XL64
changed the title
rrsettgast
requested review from
MelReyCG,
corbett5,
wrtobin and
CusiniM
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a compilation error on MacOS where the method to obtain the current memory available on host doesn't not build because _SC_AVPHYS_PAGES is not available.