Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow empty source and receivers #2818

Merged
merged 6 commits into from
Nov 28, 2023
Merged

allow empty source and receivers #2818

merged 6 commits into from
Nov 28, 2023

Conversation

tbeltzun
Copy link
Contributor

@tbeltzun tbeltzun commented Nov 13, 2023 •
edited
Loading

Allow empty source and / or receivers in a wave-propagation solver subdomain (e.g. coupled acoustic / elastic case): make the corresponding xml parameters OPTIONAL instead of REQUIRED.

xsd and rst files have been updated to reflect the changes.

Fix #2814.

@tbeltzun tbeltzun self-assigned this Nov 13, 2023
@tbeltzun tbeltzun added the type: bug Something isn't working label Nov 13, 2023
@tbeltzun tbeltzun mentioned this pull request Nov 13, 2023
Merged
4 tasks
@tbeltzun tbeltzun requested review from sframba and acitrain November 13, 2023 09:16
sframba
sframba approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@sframba sframba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might require a rebaseline

@tbeltzun tbeltzun added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Nov 13, 2023
@tbeltzun tbeltzun force-pushed the bugfix/tbeltzun/empty-source branch from 75ba40e to 6359fee Compare November 13, 2023 13:28
@tbeltzun
Copy link
Contributor Author

tbeltzun commented Nov 13, 2023 •
edited
Loading

@sframba, I've ran the integratedtests on quartz and this PR does not modify the baselines for our solvers, so this PR should be good to go once CI goes green.

@rrsettgast rrsettgast merged commit 3235553 into develop Nov 28, 2023
20 checks passed
@rrsettgast rrsettgast deleted the bugfix/tbeltzun/empty-source branch November 28, 2023 08:31
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
@tbeltzun @acitrain @ouassimkh
allow empty source and receivers (#2818)
3951251 
* make source / receivers optional

* update schema

* update `.rst` files

---------

Co-authored-by: acitrain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acitrain acitrain acitrain approved these changes

@sframba sframba sframba approved these changes

Assignees

@tbeltzun tbeltzun

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot declare an empty 2d array in xml input file
4 participants
@tbeltzun @sframba @acitrain @rrsettgast