Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Spack docker containers #3039

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

ci: Spack docker containers #3039

wants to merge 13 commits into from

Conversation

bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Mar 14, 2024 •
edited
Loading

This PR attempts to run Github Actions using Docker images with dependencies built with uberenv, spack.

Related to GEOS-DEV/thirdPartyLibs#261
Relates to GEOS-DEV/LvArray#318

@bmhan12 bmhan12 self-assigned this Mar 14, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from e88ad2b to ed09300 Compare March 28, 2024 21:02
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from 606df70 to eb9b77f Compare April 4, 2024 21:34
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Apr 18, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 3 times, most recently from 9aa2678 to ada149c Compare April 18, 2024 18:42
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Apr 18, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 3 times, most recently from d1a5ed4 to b9f7735 Compare April 18, 2024 21:58
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Apr 18, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from b9f7735 to f673591 Compare April 25, 2024 21:37
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from f673591 to a090c3b Compare May 9, 2024 16:10
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 16, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 2 times, most recently from 3188c78 to ad53f07 Compare May 23, 2024 16:29
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 30, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 2 times, most recently from 45f9942 to 76adca4 Compare May 30, 2024 18:21
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 30, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from 76adca4 to 52cdc7f Compare June 6, 2024 17:06
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jun 6, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from 52cdc7f to ce09009 Compare June 6, 2024 18:37
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jun 27, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from ce09009 to e8b3a32 Compare July 18, 2024 23:34
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from a8b644c to 2fe4997 Compare November 21, 2024 15:16
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 2 times, most recently from af83953 to 66b871a Compare December 10, 2024 15:19
This was referenced Dec 12, 2024
Open
Open
@bmhan12 bmhan12 changed the title [WIP] Spack docker containers Spack docker containers Dec 12, 2024
@bmhan12 bmhan12 added the ci: run code coverage enables running of the code coverage CI jobs label Dec 12, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from 66b871a to aabbce0 Compare December 12, 2024 19:26
@bmhan12 bmhan12 changed the title Spack docker containers ci: Spack docker containers Dec 12, 2024
@bmhan12 bmhan12 added the flag: no rebaseline Does not require rebaseline label Dec 12, 2024
@untereiner
Copy link
Contributor

Hi @bmhan12,
Is it possible to replace the TPL_TAG stored in a hidden file inside this repo by a stable tag name inside the CI scripts ? Let's say "latest" ?
Then each container configuration can be updated without the need of a commit into GEOS to update the tag.

It is also possible to tag each version of the containers with the current tags in dockerhub to pull them if needed.

@bmhan12
Copy link
Contributor Author

bmhan12 commented Dec 13, 2024

Is it possible to replace the TPL_TAG stored in a hidden file inside this repo by a stable tag name inside the CI scripts ? Let's say "latest" ?

It is probably possible, but we would need to be careful in choosing which and when images get to be "latest".

@untereiner
Copy link
Contributor

Does it make sens to say that geos develop branch should be in sync with tpl develop branch (latest commit). But when doing a geos release a corresponding release has to be done on the tpl side ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@alexbenedicto alexbenedicto Awaiting requested review from alexbenedicto alexbenedicto is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bmhan12 bmhan12

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review flag: requires updated submodule(s) flag: requires updated TPL(s) Needs a specific TPL PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmhan12 @untereiner