Umpire logs refactor - table output + adding percentages

[arng40]

Update for memory statistics table :

What we currently have :

Umpire          DEVICE sum across ranks: 15293.4 GB
Umpire          DEVICE         rank max:   31.3 GB
Umpire       DEVICE::0 sum across ranks: 15293.4 G
Umpire       DEVICE::0         rank max:   31.3 GB
Umpire            HOST sum across ranks: 7272.2 GB
Umpire            HOST         rank max:   14.7 GB
Umpire HYPRE_DEVICE_POOL sum across ranks: 7178.4 GB
Umpire HYPRE_DEVICE_POOL         rank max:   14.8 GB
Umpire          PINNED sum across ranks:  256.3 GB
Umpire          PINNED         rank max:  589.6 MB

This is what I propose inspired by the display proposed by @victorapm

+-----------------------------+---------------------+---------------------+---------------------+--------------------+
|         Umpire Memory Pool  |     Min over ranks  |    Max  over ranks  |    Avg  over ranks  |    Sum over ranks  |
|  (reserved / % over total)  |                     |                     |                     |                    |
+-----------------------------+---------------------+---------------------+---------------------+--------------------+
|                     DEVICE  |    1.4 MB   (0.0%)  |    1.7 MB   (0.0%)  |    1.5 MB   (0.0%)  |   6.1 MB   (0.0%)  |
|                  DEVICE::0  |    1.4 MB   (0.0%)  |    1.7 MB   (0.0%)  |    1.5 MB   (0.0%)  |   6.1 MB   (0.0%)  |
|                       HOST  |    2.3 MB   (0.0%)  |    2.5 MB   (0.0%)  |    2.4 MB   (0.0%)  |   9.8 MB   (0.0%)  |
|              HYPRE_UM_POOL  |  504.7 KB   (0.0%)  |  645.8 KB   (0.0%)  |  542.4 KB   (0.0%)  |   2.1 MB   (0.0%)  |
|                     PINNED  |  488.1 KB   (0.0%)  |  963.0 KB   (0.0%)  |  725.5 KB   (0.0%)  |   2.8 MB   (0.0%)  |
|                         UM  |    4.0 GB  (25.3%)  |    4.0 GB  (25.3%)  |    4.0 GB  (25.3%)  |  16.0 GB  (25.3%)  |
+-----------------------------+---------------------+---------------------+---------------------+--------------------+

Code side

• I've also refactored a bit the addUmpireHighWaterMarks() function to modern C++

[paveltomin]

@arng40 @MelReyCG any update?

[arng40]

@paveltomin
This PR is being tested by a user on a simulation to see whether the results are consistent or not

[arng40]

@paveltomin umpire values are consistent, you can have a look to the structure and let me know if it's good

[paveltomin]

@paveltomin umpire values are consistent, you can have a look to the structure and let me know if it's good

looks good, thanks

[victorapm]

Nice work! Thanks for implementing this

[rrsettgast]

@arng40 Is there something inside of umpire to do this? It might make sense to do this sort of change within umpire for all to use.

[CusiniM]

this PR has broken my mac builds. Looks like that _SC_AVPHYS_PAGES is not defined on macOS.

[herve-gross]

@CusiniM : try to replace by _SC_PHYS_PAGES

[CusiniM]

@CusiniM : try to replace by _SC_PHYS_PAGES

but are they the same thing? I have patched it like this: #3207