Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Packaging Updates #3057

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Python Packaging Updates #3057

merged 7 commits into from
Jun 21, 2024

Conversation

untereiner
Copy link
Contributor

@untereiner untereiner commented Mar 26, 2024

Associated geosPythonPackages PR: GEOS-DEV/geosPythonPackages#13

@untereiner untereiner added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Mar 26, 2024
@untereiner untereiner requested review from cssherman and TotoGaz March 26, 2024 10:53
@untereiner untereiner self-assigned this Mar 26, 2024
@untereiner untereiner removed the request for review from TotoGaz March 26, 2024 10:53
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.69%. Comparing base (d6b6e0b) to head (fe86f67).
Report is 98 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3057   +/-   ##
========================================
  Coverage    55.69%   55.69%           
========================================
  Files         1032     1032           
  Lines        87739    87739           
========================================
  Hits         48863    48863           
  Misses       38876    38876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cssherman
Copy link
Contributor

@untereiner - It looks like we'll need to update some import names in the integrated tests. I'll give this a shot and see how if the CI integrated tests step passes.

@cssherman cssherman force-pushed the feature/python_refactor branch from 6ab546e to 63273c9 Compare April 25, 2024 18:18
@cssherman cssherman force-pushed the feature/python_refactor branch from 63273c9 to d1a3606 Compare May 13, 2024 23:09
@untereiner
Copy link
Contributor Author

@cssherman there are integrated tested that are failing.. is it ok ?

Copy link
Contributor

@cssherman cssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good to go now. Let's add it to the merge queue

@cssherman cssherman changed the title test: Temporary argument for python module change testing Python Packaging Updates Jun 13, 2024
@cssherman cssherman added the type: cleanup / refactor Non-functional change (NFC) label Jun 13, 2024
@cssherman cssherman force-pushed the feature/python_refactor branch from a671f76 to fe2bb4c Compare June 13, 2024 17:34
@cssherman
Copy link
Contributor

Note: Before merging this branch, we need to do 1) Merge the changes in the linked geosPythonPackages branch, 2) Remove the temporary branch name in the cmake, and 3) Re-run the tests

@cssherman cssherman force-pushed the feature/python_refactor branch from fe2bb4c to 5ff42aa Compare June 21, 2024 16:39
@cssherman cssherman merged commit f91800b into develop Jun 21, 2024
26 checks passed
@cssherman cssherman deleted the feature/python_refactor branch June 21, 2024 19:43
Algiane pushed a commit that referenced this pull request Jul 30, 2024
Updating geosPythonPackages

---------

Co-authored-by: Christopher Sherman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants