Refactoring of the ghosting setup #3063
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3063 +/- ##
===========================================
- Coverage 56.45% 53.19% -3.26%
===========================================
Files 1022 990 -32
Lines 86431 83550 -2881
===========================================
- Hits 48794 44445 -4349
- Misses 37637 39105 +1468 ☔ View full report in Codecov by Sentry. |
This reverts commit ae9a456.
…l block to sub region mapping directly.
23 tasks
ryar9534
reviewed
Jun 26, 2024
| std::size_t const numGlbNodes = gis.nodes.get() + 1; // TODO Use strongly typed integers | ||
| std::size_t const numOwnedNodes = std::size( ownedNodesIdcs ); // TODO Use strongly typed integers | ||
|
|
||
| auto const missingIndicesMap = make_rcp< TriMap const >( numGlbMissingIndices, numGlbMissingIndices, TriGlbIdx{ 0 }, comm ); |
There was a problem hiding this comment.
Should the second argument here be numLocMissingIndices instead of the global ?
There was a problem hiding this comment.
Hmm, yes probably, I would have expected a failure then...
I guess my current test case is too simple.
* added comments for global numbering (Ryan's version) * comments for constructing owned and present mesh data (Ryan's version) * comments for construction of alocal djacency matrix data by each rank (Ryan's version) * Comments through ghostingFootprint (Ryan's version) * Comments through construction of GhostSend/GhostRecv for each rank (Ryan's version) * complete comments for performGhosting (Ryan's version) * Update comments about sorting following fix * finished comments of doTheNewGhosting (Ryan's version) * make new ghosting active/deactive by setting command line flag (-g 1)
This reverts commit a62ce3a.
…what I think is non-contiguous local indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.