♻️🔇 removing debug outputs + prefering move(host) instead of freeOnDe…

…vice()

src/coreComponents/physicsSolvers/fluidFlow/StencilDataCollection.cpp

@@ -89,7 +89,7 @@
     } catch( BadTypeError const & e )
     {
       // only TPFA is supported for now
       GEOS_ERROR( GEOS_FMT( "{}: target discretization is not supported by {} (for now, only '{}' is).",
                             getDataContext(), catalogName(), TwoPointFluxApproximation::catalogName() ) );
     }
   }
@@ -166,20 +166,6 @@
     IndexContainerType const & elemSubRegionIndices = stencilWrapper.getElementSubRegionIndices();
     IndexContainerType const & elementIndices = stencilWrapper.getElementIndices();
 
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} = {}", "elemRegionIndices size", elemRegionIndices.size() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} = {}", "elemSubRegionIndices size", elemSubRegionIndices.size() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} = {}", "elementIndices size", elementIndices.size() ) );
-    RAJA::ReduceSum< parallelDeviceReduce, int > runCount( 0 ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMin< parallelDeviceReduce, localIndex > minLclId( std::numeric_limits< localIndex >::max() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMax< parallelDeviceReduce, localIndex > maxLclId( std::numeric_limits< localIndex >::min() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMin< parallelDeviceReduce, localIndex > minRegId( std::numeric_limits< localIndex >::max() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMax< parallelDeviceReduce, localIndex > maxRegId( std::numeric_limits< localIndex >::min() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMin< parallelDeviceReduce, localIndex > minSubRegId( std::numeric_limits< localIndex >::max() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMax< parallelDeviceReduce, localIndex > maxSubRegId( std::numeric_limits< localIndex >::min() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMin< parallelDeviceReduce, localIndex > minElemId( std::numeric_limits< localIndex >::max() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMax< parallelDeviceReduce, localIndex > maxElemId( std::numeric_limits< localIndex >::min() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMin< parallelDeviceReduce, real64 > minTransmiId( std::numeric_limits< real64 >::max() ); // FOR DEBUG OUTPUT
-    RAJA::ReduceMax< parallelDeviceReduce, real64 > maxTransmiId( std::numeric_limits< real64 >::min() ); // FOR DEBUG OUTPUT
     forAll< POLICY >( stencilWrapper.size(), [=] GEOS_HOST_DEVICE ( localIndex const iConn )
     {
       real64 transmissibility[1][2];
@@ -197,33 +183,9 @@
         connData[iConn].m_regionId[i] = elemRegionIndices( iConn, i );
         connData[iConn].m_subRegionId[i] = elemSubRegionIndices( iConn, i );
         connData[iConn].m_elementId[i] = elementIndices( iConn, i );
-        minRegId.min( elemRegionIndices( iConn, i ) );       maxRegId.max( elemRegionIndices( iConn, i ) );
-        minSubRegId.min( elemSubRegionIndices( iConn, i ) ); maxSubRegId.max( elemSubRegionIndices( iConn, i ) );
-        minElemId.min( elementIndices( iConn, i ) );         maxElemId.max( elementIndices( iConn, i ) );
-        minTransmiId.min( transmissibility[0][i] );          maxTransmiId.max( transmissibility[0][i] );
       }
-      runCount+=1;
-      minLclId.min( iConn );
-      maxLclId.max( iConn );
     } );
-    connData.freeOnDevice();
-    // DEBUG OUTPUTS
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} = {}", "run count", runCount.get() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} : {} -> {}", "lcl ids         ", minLclId.get(), maxLclId.get() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} : {} -> {}", "elem reg ids    ", minRegId.get(), maxRegId.get() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} : {} -> {}", "elem sub reg ids", minSubRegId.get(), maxSubRegId.get() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} : {} -> {}", "elem ids        ", minElemId.get(), maxElemId.get() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel {} : {} -> {}", "transmissibility", minTransmiId.get(), maxTransmiId.get() ) );
-    GEOS_LOG( GEOS_FMT( "StencilDataCollection::Kernel first line : transmi[{},{},{},0] = {} ; transmi[{},{},{},1] = {}",
-                        connData[0].m_regionId[0],
-                        connData[0].m_subRegionId[0],
-                        connData[0].m_elementId[0],
-                        connData[0].m_transmissibility[0],
-                        connData[0].m_regionId[1],
-                        connData[0].m_subRegionId[1],
-                        connData[0].m_elementId[1],
-                        connData[0].m_transmissibility[1] ) );
-    GEOS_LOG( showKernelDataExtract( connData, 8 ) );
+    connData.move( LvArray::MemorySpace::host );
   }
 
 private:
@@ -261,25 +223,25 @@
 }
 
 
-string showKernelDataExtract( arrayView1d< StencilDataCollection::KernelConnectionData > const & kernelData,
-                              globalIndex maxLines )
+string formatKernelDataExtract( arrayView1d< StencilDataCollection::KernelConnectionData > const & kernelData,
+                                globalIndex maxLines )
 {
   TableData tableData;
   auto kernelIterator = kernelData.begin();
   for( int iConn=0; iConn < maxLines && kernelIterator != kernelData.end(); ++iConn, ++kernelIterator )
   {
     tableData.addRow( GEOS_FMT( "{} / {}", kernelIterator->m_regionId[0], kernelIterator->m_regionId[1] ),
                       GEOS_FMT( "{} / {}", kernelIterator->m_subRegionId[0], kernelIterator->m_subRegionId[1] ),
                       GEOS_FMT( "{} / {}", kernelIterator->m_elementId[0], kernelIterator->m_elementId[1] ),
                       kernelIterator->m_transmissibility[0],
                       kernelIterator->m_transmissibility[1] );
   }
   TableLayout const tableLayout{
     { "regionId A/B", "subRegionId A/B", "elementId A/B", "transmissibilityAB", "transmissibilityBA" },
     GEOS_FMT( "Kernel data (real row count = {})", kernelData.size() )
   };
   TableTextFormatter const tableFormatter{ tableLayout };
   return tableFormatter.toString( tableData );
 }
 
 void StencilDataCollection::storeConnectionData( string_view stencilName,
@@ -303,7 +265,7 @@
   { // data storing
     GEOS_ERROR_IF_NE_MSG( size_t( m_cellAGlobalId.size() ), size_t( sortedData.size() ),
                           GEOS_FMT( "{}: Unexpected stencil size!\n{}",
-                                    getDataContext(), showKernelDataExtract( kernelData, 8 ) ) );
+                                    getDataContext(), formatKernelDataExtract( kernelData, 8 ) ) );
     globalIndex i = 0;
     for( ConnectionData const & conn : sortedData )
     {