Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing const for int conversion of CommID #3122

Merged
merged 2 commits into from
May 14, 2024

Conversation

TotoGaz
Copy link
Contributor

@TotoGaz TotoGaz commented May 13, 2024

No description provided.

@TotoGaz TotoGaz added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: no rebaseline Does not require rebaseline labels May 13, 2024
@TotoGaz TotoGaz requested a review from CusiniM May 13, 2024 20:42
@TotoGaz TotoGaz self-assigned this May 13, 2024
@TotoGaz TotoGaz requested a review from ryar9534 May 13, 2024 20:43
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.57%. Comparing base (a1fec52) to head (287adb9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3122   +/-   ##
========================================
  Coverage    53.57%   53.57%           
========================================
  Files         1003     1003           
  Lines        85289    85289           
========================================
+ Hits         45694    45696    +2     
+ Misses       39595    39593    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TotoGaz TotoGaz changed the title Fix missing const for int conversion of CommID Fix missing const for int conversion of CommID May 13, 2024
@TotoGaz TotoGaz added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label May 14, 2024
@TotoGaz TotoGaz merged commit db7cc5d into develop May 14, 2024
26 checks passed
@TotoGaz TotoGaz deleted the bugfix/TotoGaz/fixMissingConst branch May 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants