-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate fluid models #3123
Merged
Merged
Activate fluid models #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkachuma
added
type: cleanup / refactor
Non-functional change (NFC)
flag: requires rebaseline
Requires rebaseline branch in integratedTests
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
labels
May 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3123 +/- ##
========================================
Coverage 53.70% 53.70%
========================================
Files 1010 1010
Lines 85637 85639 +2
========================================
+ Hits 45990 45993 +3
+ Misses 39647 39646 -1 ☔ View full report in Codecov by Sentry. |
dkachuma
removed
flag: requires rebaseline
Requires rebaseline branch in integratedTests
labels
May 14, 2024
dkachuma
removed
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
labels
May 14, 2024
paveltomin
reviewed
May 14, 2024
...Components/constitutive/fluid/multifluid/compositional/models/NegativeTwoPhaseFlashModel.hpp
Show resolved
Hide resolved
paveltomin
approved these changes
May 14, 2024
bmhan12
reviewed
May 17, 2024
src/coreComponents/constitutive/fluid/multifluid/MultiFluidSelector.hpp
Outdated
Show resolved
Hide resolved
dkachuma
added
the
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
label
May 22, 2024
paveltomin
added
flag: no rebaseline
Does not require rebaseline
and removed
flag: ready for review
labels
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: no rebaseline
Does not require rebaseline
type: cleanup / refactor
Non-functional change (NFC)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates some fluid models in
MultiFluidSelector.hpp
only for CPU builds. The issue is that when activated for CUDA builds, these extra models cause compilation failures for some of the GHA pipelines. These are therefore currently being activated only for non-device builds.