feat: Temperature dependent Thermal Expansion Coefficient #3185

sytuannguyen · 2024-06-25T02:43:47Z

This PR implement the non-linear Thermo-Elastic behavior related to non constant Thermal Expansion Coefficient (TEC). Either a linear law or a table could be considered for defining TEC vs Temperature.

Update the Porous Solid/Solid Base constitutive behavior to allow temperature dependent TEC
Implement TEC table
Example, Doc, Python script for validation
Integrated tests
Include thermally-induced stress in effective stress update

codecov · 2024-07-01T03:12:13Z

Codecov Report

Attention: Patch coverage is 68.94410% with 50 lines in your changes missing coverage. Please review.

Project coverage is 57.18%. Comparing base (b3592de) to head (36ecb80).

Files with missing lines	Patch %	Lines
.../coreComponents/constitutive/solid/PorousSolid.hpp	0.00%	33 Missing ⚠️
...rc/coreComponents/constitutive/solid/SolidBase.hpp	46.15%	7 Missing ⚠️
...oreComponents/constitutive/solid/DruckerPrager.hpp	50.00%	2 Missing ⚠️
...nents/constitutive/solid/DruckerPragerExtended.hpp	50.00%	2 Missing ⚠️
...Components/constitutive/solid/ElasticIsotropic.hpp	66.66%	2 Missing ⚠️
...tutive/solid/ElasticIsotropicPressureDependent.hpp	50.00%	2 Missing ⚠️
...eComponents/constitutive/solid/ModifiedCamClay.hpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3185      +/-   ##
===========================================
+ Coverage    56.82%   57.18%   +0.35%     
===========================================
  Files         1154     1159       +5     
  Lines        99983   100133     +150     
===========================================
+ Hits         56818    57263     +445     
+ Misses       43165    42870     -295

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

herve-gross

Great work, Sy Tuan.

jhuang2601 · 2024-10-09T17:02:51Z

src/coreComponents/constitutive/solid/PorousSolid.hpp

+    LvArray::tensorOps::symAddIdentity< 3 >( totalStress, thermalStressIncrement );
+
+    // Save rock stress including the contribution of temperature change.
+    m_solidUpdate.saveStress( k, q, totalStress );


Nice change for computing effective stress to include thermal component.

jhuang2601 · 2024-10-09T17:21:12Z

Hello @rrsettgast and @CusiniM, this PR is almost ready for merge and would appreciate if you take a final review.

jhuang2601 · 2024-10-09T17:28:24Z

This failure is always reported for GEOS CI / Rockylinux CUDA (8, clang 17.0.6, cuda 12.5.1):

The following tests FAILED:
	 90 - testLifoStorage (Subprocess aborted)
Errors while running CTest

The problem is being handled by #3387

src/coreComponents/constitutive/solid/PorousSolid.hpp

CusiniM · 2024-11-05T00:17:36Z

src/coreComponents/constitutive/solid/PorousSolid.hpp

+    real64 dThermalExpansionCoefficient_dTemperature;
+    real64 thermalExpansionCoefficient;
+
+    if( m_drainedTECTableName == nullptr || m_drainedTECTableName[0] == '\0' )


what's happening here? This seems hacky and it's in a device function...

Yes this is a hack to pass the GPU build after many trials & errors. It is welcome if you have another solution that is more suitable to you.

what is this trying to achieve? Can you present to us at one of the dedicated dev meetings what you are trying to do.

Maybe cast m_drainedTECTableName into a bool on host and then pass the bool to PorousSolidUpdates.

src/coreComponents/constitutive/solid/PorousSolid.hpp

src/coreComponents/constitutive/solid/SolidBase.cpp

CusiniM · 2024-11-05T00:20:15Z

src/coreComponents/constitutive/solid/SolidBase.hpp

@@ -121,11 +133,31 @@ class SolidBaseUpdates
   * @return the thermalExpansionCoefficient of element k
   */
  GEOS_HOST_DEVICE
-  real64 getThermalExpansionCoefficient( localIndex const k ) const
+  virtual real64 getThermalExpansionCoefficient( localIndex const k ) const


why do you want this to be virtual? It's okay if you are just trying to enforce that function is implemented everywhere but keep in mind that there are no vtables on device. These functions can't be used as proper virtual functions.

virtual is added to make it consistent with the existing getters of bulk and shear moduli.

CusiniM · 2024-11-05T00:22:45Z

src/coreComponents/constitutive/unitTests/testElasticTransverseIsotropic.cpp

+  // Test that the default TEC derivative w.r.t. temperature and the default reference temperature are nil.
+  EXPECT_DOUBLE_EQ( updates.m_dThermalExpansionCoefficient_dTemperature, 0 );
+  EXPECT_DOUBLE_EQ( updates.m_referenceTemperature, 0 );


do we need these tests? I mean having self-contained tests for the constitutive models is a good idea but it's unclear to me why you need to test this. Aren't you assigning this as default value?

These unit tests were added to pass one of the CI build that requires to cover a certain % of the code. Again, I am totally ok if you have another option that is more suitable to you.

that CI test is not mandatory for merging.

…ub.com/GEOS-DEV/GEOS into feature/sytuan/temperatureDependentTEC

dkachuma · 2025-01-13T21:20:21Z

src/coreComponents/constitutive/solid/SolidBase.hpp

+    static constexpr char const * dThermalExpansionCoefficient_dTemperatureString() { return "dDrainedTEC_dT"; }
+    static constexpr char const * referenceTemperatureString() { return "referenceTemperature"; }
+
+    static constexpr char const * drainedTECTableNameString() { return "drainedTECTableName"; }


I would add a validator here. To ensure that if the user provides a table name, then the relevant TableFunction exists.

dkachuma · 2025-01-13T21:23:16Z

src/coreComponents/constitutive/unitTests/testCeramicDamage.cpp

+using namespace geos;
+using namespace ::geos::constitutive;
+
+TEST( CeramicDamageTests, testThermalExpansionAndTemperature )


I expected this to test some of the kernel functions. Is there a plan for that perhaps?

implement temperature dependent TEC

722a44b

sytuannguyen self-assigned this Jun 25, 2024

sytuannguyen added 7 commits June 25, 2024 09:55

define dTEC_dT at SolidBase level

8266f4b

add dTEC_dT getter and update all the solid constitutive classes

901b1c0

use the dTEC_dT getter to get param from XML

29f63b1

uncrustify_style

1d11035

add XMLs for benchmark and integrated test

34cc058

add Python script for validation

6b2d15f

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

f9c5e54

sytuannguyen marked this pull request as ready for review July 1, 2024 01:59

sytuannguyen added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jul 1, 2024

sytuannguyen requested review from jhuang2601 and herve-gross July 1, 2024 02:02

sytuannguyen force-pushed the feature/sytuan/temperatureDependentTEC branch from 5fe7e2f to f9c5e54 Compare July 1, 2024 06:41

sytuannguyen marked this pull request as draft July 1, 2024 06:43

sytuannguyen added 4 commits July 1, 2024 08:52

add TEC table name

aaff949

implement TEC table

31f654c

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

57482a6

uncrustify_style

a859e4a

sytuannguyen marked this pull request as ready for review July 11, 2024 02:22

sytuannguyen requested review from rrsettgast, CusiniM, dkachuma and cssherman as code owners July 11, 2024 02:22

sytuannguyen added ci: run integrated tests Allows to run the integrated tests in GEOS CI changes XML input flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request labels Jul 11, 2024

sytuannguyen changed the title ~~Temperature dependent Thermal Expansion Coefficient~~ A new feature : Temperature dependent Thermal Expansion Coefficient Jul 11, 2024

Wordsmithing

e2fbef8

herve-gross approved these changes Oct 7, 2024

View reviewed changes

jhuang2601 added 7 commits October 8, 2024 16:04

seperate the xml files into two cases to avoid confusion

22e792d

update python script and add output files

7d601aa

update rst file

7a0868a

fix links in rst file

c440825

Wordsmithing

aea6fce

add a doc and rearrange files

4800054

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

5a750e5

jhuang2601 approved these changes Oct 9, 2024

View reviewed changes

jhuang2601 requested a review from npillardou October 10, 2024 15:47

jhuang2601 added 5 commits October 16, 2024 09:15

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

050e598

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

7b6fad1

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

b8c4d80

add smoke tests to integratedTest

f1eb82a

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

3f264f8

CusiniM reviewed Nov 5, 2024

View reviewed changes

jhuang2601 and others added 5 commits November 7, 2024 16:25

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

c0b8681

update xmls with defaultDrainedTEC

d5446c2

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

28d9c48

Merge branch 'feature/sytuan/temperatureDependentTEC' of https://gith…

827afe5

…ub.com/GEOS-DEV/GEOS into feature/sytuan/temperatureDependentTEC

address comments

2b6005b

sytuannguyen requested review from castelletto1 and frankfeifan as code owners November 8, 2024 08:44

jhuang2601 added 3 commits November 11, 2024 08:55

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

e3076ce

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

a579f4c

Merge branch 'develop' into feature/sytuan/temperatureDependentTEC

36ecb80

dkachuma reviewed Jan 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Temperature dependent Thermal Expansion Coefficient #3185

feat: Temperature dependent Thermal Expansion Coefficient #3185

sytuannguyen commented Jun 25, 2024 •

edited by jhuang2601

Loading

codecov bot commented Jul 1, 2024 •

edited

Loading

herve-gross left a comment

jhuang2601 Oct 9, 2024

jhuang2601 commented Oct 9, 2024

jhuang2601 commented Oct 9, 2024 •

edited

Loading

CusiniM Nov 5, 2024

sytuannguyen Nov 7, 2024 •

edited

Loading

CusiniM Nov 8, 2024

dkachuma Jan 13, 2025

CusiniM Nov 5, 2024

sytuannguyen Nov 8, 2024

CusiniM Nov 5, 2024

sytuannguyen Nov 7, 2024 •

edited

Loading

CusiniM Nov 8, 2024

dkachuma Jan 13, 2025

dkachuma Jan 13, 2025

feat: Temperature dependent Thermal Expansion Coefficient #3185

Are you sure you want to change the base?

feat: Temperature dependent Thermal Expansion Coefficient #3185

Conversation

sytuannguyen commented Jun 25, 2024 • edited by jhuang2601 Loading

codecov bot commented Jul 1, 2024 • edited Loading

Codecov Report

herve-gross left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhuang2601 commented Oct 9, 2024

jhuang2601 commented Oct 9, 2024 • edited Loading

Choose a reason for hiding this comment

sytuannguyen Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sytuannguyen Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sytuannguyen commented Jun 25, 2024 •

edited by jhuang2601

Loading

codecov bot commented Jul 1, 2024 •

edited

Loading

jhuang2601 commented Oct 9, 2024 •

edited

Loading

sytuannguyen Nov 7, 2024 •

edited

Loading

sytuannguyen Nov 7, 2024 •

edited

Loading