-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geothermal Gradient for Single Phase flow #3193
base: develop
Are you sure you want to change the base?
Geothermal Gradient for Single Phase flow #3193
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3193 +/- ##
===========================================
- Coverage 55.77% 55.77% -0.01%
===========================================
Files 1035 1035
Lines 87914 87924 +10
===========================================
+ Hits 49035 49040 +5
- Misses 38879 38884 +5 ☔ View full report in Codecov by Sentry. |
tempTableGradient = true; | ||
string const tempTableName = fs.getTemperatureVsElevationTableName(); | ||
TableFunction const & tempTable = functionManager.getGroup< TableFunction >( tempTableName ); | ||
tempTableWrapper = tempTable.createKernelWrapper(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be used in HydrostaticPressureKernel
, no? i mean let's say density formally depends on temperature, then temperature should be used there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree with you, we should modify the kernel into something like:
HydrostaticPressureKernel::launch( numPointsInTable,
maxNumEquilIterations,
equilTolerance,
gravVector,
minElevation,
elevationIncrement,
datumElevation,
datumPressure,
fluidWrapper,
tempTableWrapper,
elevationValues.toNestedView(),
pressureValues.toView() );
But behind that, it requires further developments in the constitutive also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But behind that, it requires further developments in the constitutive also
can you elaborate?
The purpose of this PR is to add the geothermal gradient capacities for single-phase flow.
At the moment the temperature VS Elevation is correlated with the composition VS Elevation, maybe this point could be extended to something that is independent of the composition:
Further work is needed to account for composition in the hydrostatic pressure kernel, as it is done in CompositionalMultiphaseFlow.