Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geothermal Gradient for Single Phase flow #3193

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

npillardou
Copy link

@npillardou npillardou commented Jun 28, 2024

The purpose of this PR is to add the geothermal gradient capacities for single-phase flow.

At the moment the temperature VS Elevation is correlated with the composition VS Elevation, maybe this point could be extended to something that is independent of the composition:

<HydrostaticEquilibrium
  name="Initialisation"
  datumElevation="-3790"
  datumPressure="4.3e7"
  objectPath="ElementRegions"
  initialPhaseName="water"
  componentNames="{ co2, water }"
  componentFractionVsElevationTableNames="{ CO2VD, H2OVD }"
  temperatureVsElevationTableName="initTempTable" />  

Further work is needed to account for composition in the hydrostatic pressure kernel, as it is done in CompositionalMultiphaseFlow.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.77%. Comparing base (f05008b) to head (e0ff166).

Files Patch % Lines
...nents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp 54.54% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
- Coverage    55.77%   55.77%   -0.01%     
===========================================
  Files         1035     1035              
  Lines        87914    87924      +10     
===========================================
+ Hits         49035    49040       +5     
- Misses       38879    38884       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tempTableGradient = true;
string const tempTableName = fs.getTemperatureVsElevationTableName();
TableFunction const & tempTable = functionManager.getGroup< TableFunction >( tempTableName );
tempTableWrapper = tempTable.createKernelWrapper();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be used in HydrostaticPressureKernel, no? i mean let's say density formally depends on temperature, then temperature should be used there

Copy link
Author

@npillardou npillardou Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree with you, we should modify the kernel into something like:

HydrostaticPressureKernel::launch( numPointsInTable,
maxNumEquilIterations,
equilTolerance,
gravVector,
minElevation,
elevationIncrement,
datumElevation,
datumPressure,
fluidWrapper,
tempTableWrapper,
elevationValues.toNestedView(),
pressureValues.toView() );

But behind that, it requires further developments in the constitutive also

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But behind that, it requires further developments in the constitutive also

can you elaborate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants