fix: Use aperture table in poromechanics with conforming fractures #3194

paveltomin · 2024-06-28T16:53:20Z

Main thing:
replace
hydraulicAperture[k] = minimumHydraulicAperture[k] + aperture[k];
with
hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump );
for poromechanics with conforming fractures.
At least this way there will be no negative aperture and no negative volume.

Small things:

Separately account for new slip in computeFractureStateStatistics to see new segments slipped.
Output normal displacement tolerance, sliding tolerance, normal traction tolerance when logLevel>=2.
For logLevel>=10 - display fracture state changes with debug information.
Small fixes for deltaVolume logic: assign it to 0 once applied into volume (to avoid double counting), update mass with updated volume. Those are important for fractures after poromechanics initialization that changes the volume of the fractures.

paveltomin · 2024-06-28T17:13:35Z

src/coreComponents/physicsSolvers/contact/SolidMechanicsALMKernels.hpp

@@ -406,8 +406,8 @@ struct ComputeRotationMatricesKernel
    forAll< POLICY >( size, [=] GEOS_HOST_DEVICE ( localIndex const k )
    {

-      localIndex const & f0 = elemsToFaces[k][0];
-      localIndex const & f1 = elemsToFaces[k][1];
+      localIndex const f0 = elemsToFaces[k][0];


this is just to avoid gcc warnings

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp

codecov · 2024-06-28T18:17:22Z

Codecov Report

Attention: Patch coverage is 2.43902% with 80 lines in your changes missing coverage. Please review.

Project coverage is 55.72%. Comparing base (94a0e86) to head (59f42d2).
Report is 4 commits behind head on develop.

Files	Patch %	Lines
...sSolvers/contact/SolidMechanicsLagrangeContact.cpp	0.00%	44 Missing ⚠️
...cs/SinglePhasePoromechanicsConformingFractures.cpp	0.00%	17 Missing ⚠️
...nents/physicsSolvers/contact/ContactSolverBase.cpp	0.00%	14 Missing ⚠️
...hysicsSolvers/contact/SolidMechanicsALMKernels.hpp	0.00%	2 Missing ⚠️
...anicsKernels/SinglePhasePoromechanicsFractures.hpp	0.00%	2 Missing ⚠️
...nents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3194      +/-   ##
===========================================
- Coverage    55.75%   55.72%   -0.03%     
===========================================
  Files         1041     1041              
  Lines        88534    88571      +37     
===========================================
- Hits         49358    49357       -1     
- Misses       39176    39214      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Guotong-Ren · 2024-07-01T21:11:12Z

is hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump ) essentially using aperture table?

paveltomin · 2024-07-01T22:59:01Z

is hydraulicAperture[k] = contactWrapper.computeHydraulicAperture( aperture[k], dHydraulicAperture_dNormalJump ) essentially using aperture table?

yes

CusiniM · 2024-07-01T23:36:12Z

src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp

@@ -217,7 +218,9 @@ void SinglePhasePoromechanicsConformingFractures< FLOW_SOLVER >::assembleCouplin
  {
    /// 3. assemble Force Residual w.r.t. pressure and Flow mass residual w.r.t. displacement
    assembleForceResidualDerivativeWrtPressure( mesh, regionNames, dofManager, localMatrix, localRhs );
+//            std::cout << "assembleForceResidualDerivativeWrtPressure RHS " << localRhs[96609] << std::endl;


Suggested change

// std::cout << "assembleForceResidualDerivativeWrtPressure RHS " << localRhs[96609] << std::endl;

CusiniM · 2024-07-01T23:36:19Z

src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp

    assembleFluidMassResidualDerivativeWrtDisplacement( mesh, regionNames, dofManager, localMatrix, localRhs );
+//            std::cout << "assembleFluidMassResidualDerivativeWrtDisplacement RHS " << localRhs[96609] << std::endl;


Suggested change

// std::cout << "assembleFluidMassResidualDerivativeWrtDisplacement RHS " << localRhs[96609] << std::endl;

…nto pt/debug-contact

paveltomin · 2024-07-05T22:52:27Z

I checked the tests are results are ok, all changes are expected

CusiniM · 2024-07-05T23:06:22Z

src/coreComponents/physicsSolvers/contact/SolidMechanicsLagrangeContact.cpp

-                fractureState[kfe] = contact::FractureState::Stick;
+                fractureState[kfe] = FractureState::Stick;
+                if( getLogLevel() >= 10 )
+                  GEOS_LOG( GEOS_FMT( "{}: {} -> {}: dispJump = {}, normalDisplacementTolerance = {}",


it would be better to avoid this logging inside the cell loop.

…3194) * decouple debug matrix output from logLevel * Update SolidMechanicsLagrangeContact.cpp * Update SinglePhasePoromechanicsConformingFractures.cpp * Update SolidMechanicsLagrangeContact.cpp * Update SurfaceElementSubRegion.hpp * Update SinglePhaseBase.cpp * Update HydrofractureSolver.cpp * Update .integrated_tests.yaml * Update BASELINE_NOTES.md --------- Co-authored-by: Pavel Tomin <“[email protected]”>

Pavel Tomin and others added 6 commits June 21, 2024 12:33

decouple debug matrix output from logLevel

adbd3c2

Merge remote-tracking branch 'origin/develop' into pt/write-matrix

c036976

victor's suggestions

65fa11a

debug contact

ffea8de

Merge branch 'develop' into pt/debug-contact

06c5d84

code style and remove debug

d7df1f0

paveltomin commented Jun 28, 2024

View reviewed changes

paveltomin added 3 commits June 28, 2024 12:16

Update SolidMechanicsLagrangeContact.cpp

1ba9393

Update SinglePhasePoromechanicsConformingFractures.cpp

194602b

Update SolidMechanicsLagrangeContact.cpp

2950eaa

paveltomin commented Jun 28, 2024

View reviewed changes

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp Outdated Show resolved Hide resolved

paveltomin self-assigned this Jun 28, 2024

paveltomin marked this pull request as ready for review June 28, 2024 17:33

paveltomin requested review from CusiniM, matteofrigo5, castelletto1 and jhuang2601 June 28, 2024 17:33

paveltomin changed the title ~~Pt/debug contact~~ Use aperture table in poromechanics with conforming fractures Jun 28, 2024

paveltomin added the flag: ready for review label Jun 28, 2024

fix build

c678634

paveltomin requested review from sohailwaziri and Guotong-Ren July 1, 2024 16:21

CusiniM reviewed Jul 1, 2024

View reviewed changes

CusiniM approved these changes Jul 1, 2024

View reviewed changes

Guotong-Ren approved these changes Jul 2, 2024

View reviewed changes

paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jul 2, 2024

paveltomin added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Jul 3, 2024

Pavel Tomin and others added 13 commits July 3, 2024 18:05

fix edfm

5f22591

revert and try another way

d9b7330

build fix

d5ddb7f

this should work

b12f753

Update SurfaceElementSubRegion.hpp

47e17f1

one last try

8c7a8d6

Merge branch 'pt/debug-contact' of https://github.com/GEOS-DEV/GEOS i…

90923b9

…nto pt/debug-contact

revert and give up

fa97b6a

Update SinglePhaseBase.cpp

3839b4a

Update SinglePhaseBase.cpp

45b2ca0

revert

17dc67e

Merge branch 'pt/debug-contact' of https://github.com/GEOS-DEV/GEOS i…

3b5fc93

…nto pt/debug-contact

Update HydrofractureSolver.cpp

cae43ba

CusiniM reviewed Jul 5, 2024

View reviewed changes

ryar9534 mentioned this pull request Jul 6, 2024

refactor: fix creation of mass handling. #3215

Merged

rrsettgast approved these changes Jul 6, 2024

View reviewed changes

rrsettgast added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jul 9, 2024

paveltomin removed the flag: ready for review label Jul 10, 2024

Merge branch 'develop' into pt/debug-contact

e5ba0ce

paveltomin requested review from klevzoff and francoishamon as code owners July 10, 2024 15:06

paveltomin changed the title ~~Use aperture table in poromechanics with conforming fractures~~ fix: Use aperture table in poromechanics with conforming fractures Jul 10, 2024

jhuang2601 approved these changes Jul 10, 2024

View reviewed changes

paveltomin added 2 commits July 10, 2024 11:13

Update .integrated_tests.yaml

07a4d1d

Update BASELINE_NOTES.md

59f42d2

rrsettgast merged commit 6c82021 into develop Jul 10, 2024
26 of 28 checks passed

rrsettgast deleted the pt/debug-contact branch July 10, 2024 21:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use aperture table in poromechanics with conforming fractures #3194

fix: Use aperture table in poromechanics with conforming fractures #3194

paveltomin commented Jun 28, 2024 •

edited

Loading

paveltomin Jun 28, 2024

codecov bot commented Jun 28, 2024 •

edited

Loading

Guotong-Ren commented Jul 1, 2024

paveltomin commented Jul 1, 2024

CusiniM Jul 1, 2024

CusiniM Jul 1, 2024

paveltomin commented Jul 5, 2024

CusiniM Jul 5, 2024

		assembleFluidMassResidualDerivativeWrtDisplacement( mesh, regionNames, dofManager, localMatrix, localRhs );
		// std::cout << "assembleFluidMassResidualDerivativeWrtDisplacement RHS " << localRhs[96609] << std::endl;

fix: Use aperture table in poromechanics with conforming fractures #3194

fix: Use aperture table in poromechanics with conforming fractures #3194

Conversation

paveltomin commented Jun 28, 2024 • edited Loading

paveltomin Jun 28, 2024

Choose a reason for hiding this comment

codecov bot commented Jun 28, 2024 • edited Loading

Codecov Report

Guotong-Ren commented Jul 1, 2024

paveltomin commented Jul 1, 2024

CusiniM Jul 1, 2024

Choose a reason for hiding this comment

CusiniM Jul 1, 2024

Choose a reason for hiding this comment

paveltomin commented Jul 5, 2024

CusiniM Jul 5, 2024

Choose a reason for hiding this comment

paveltomin commented Jun 28, 2024 •

edited

Loading

codecov bot commented Jun 28, 2024 •

edited

Loading