Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable CODEOWNERS #3205

Merged
merged 10 commits into from
Jul 9, 2024
Merged

feat: enable CODEOWNERS #3205

merged 10 commits into from
Jul 9, 2024

Conversation

rrsettgast
Copy link
Member

@rrsettgast rrsettgast commented Jul 2, 2024

This PR adds the CODEOWNERS file which will be used for enforcing reviews by specific individuals (code owners) on specific subdirectories.

@castelletto1 @CusiniM @herve-gross @TotoGaz @paveltomin please look at the file and submit changes.

.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just suggesting a few additions. I wonder if we should always have at least 2 ppl so that we are never blocked by someone's absence (e.g., someone goes on vacation for 2 weeks).

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@TotoGaz TotoGaz removed their assignment Jul 3, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@rrsettgast rrsettgast marked this pull request as ready for review July 8, 2024 23:16
@rrsettgast rrsettgast changed the title introduce CODEOWNERS feat: introduce CODEOWNERS Jul 8, 2024
@rrsettgast rrsettgast changed the title feat: introduce CODEOWNERS feat: enable CODEOWNERS Jul 8, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.75%. Comparing base (94a0e86) to head (618b2fb).
Report is 89 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3205   +/-   ##
========================================
  Coverage    55.75%   55.75%           
========================================
  Files         1041     1041           
  Lines        88534    88534           
========================================
  Hits         49358    49358           
  Misses       39176    39176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast rrsettgast merged commit a3b438d into develop Jul 9, 2024
31 of 50 checks passed
@rrsettgast rrsettgast deleted the feature/addCodeOwners branch July 9, 2024 18:32
@paveltomin
Copy link
Contributor

@rrsettgast is it possible to disable that for drafts?

@MelReyCG
Copy link
Contributor

MelReyCG commented Jul 18, 2024

@paveltomin isn't it already "silenced" for draft? I think we only see the codeowners on drafts, but don't actually send notifications.

@paveltomin
Copy link
Contributor

@paveltomin isn't it already "silenced" for draft? I think we only see the codeowners on drafts, but don't actually send notifications.

I am not sure if it is silenced or not, sorry
I just saw people getting added as reviewers for drafts and got confused if that will trigger notifications for them

Algiane pushed a commit that referenced this pull request Jul 30, 2024
* Add CODEOWNERS file

Co-authored-by: Matteo Cusini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants