-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable CODEOWNERS #3205
feat: enable CODEOWNERS #3205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just suggesting a few additions. I wonder if we should always have at least 2 ppl so that we are never blocked by someone's absence (e.g., someone goes on vacation for 2 weeks).
Co-authored-by: Matteo Cusini <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3205 +/- ##
========================================
Coverage 55.75% 55.75%
========================================
Files 1041 1041
Lines 88534 88534
========================================
Hits 49358 49358
Misses 39176 39176 ☔ View full report in Codecov by Sentry. |
@rrsettgast is it possible to disable that for drafts? |
@paveltomin isn't it already "silenced" for draft? I think we only see the codeowners on drafts, but don't actually send notifications. |
I am not sure if it is silenced or not, sorry |
* Add CODEOWNERS file Co-authored-by: Matteo Cusini <[email protected]>
This PR adds the CODEOWNERS file which will be used for enforcing reviews by specific individuals (code owners) on specific subdirectories.
@castelletto1 @CusiniM @herve-gross @TotoGaz @paveltomin please look at the file and submit changes.