-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use stability test in flash #3206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' into feature/dkachuma/eos-parameters
dkachuma
changed the title
Use stability test in flash
feature: Use stability test in flash
Jul 18, 2024
dkachuma
changed the title
feature: Use stability test in flash
feat: Use stability test in flash
Jul 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3206 +/- ##
===========================================
+ Coverage 56.01% 56.36% +0.34%
===========================================
Files 1053 1056 +3
Lines 89115 89233 +118
===========================================
+ Hits 49919 50294 +375
+ Misses 39196 38939 -257 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
review? |
paveltomin
approved these changes
Aug 12, 2024
CusiniM
approved these changes
Aug 12, 2024
dkachuma
added
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
flag: no rebaseline
Does not require rebaseline
labels
Aug 13, 2024
corbett5
approved these changes
Aug 16, 2024
corbett5
reviewed
Aug 16, 2024
CusiniM
added
the
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
label
Aug 26, 2024
rrsettgast
pushed a commit
that referenced
this pull request
Sep 17, 2024
rrsettgast
pushed a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: no rebaseline
Does not require rebaseline
flag: ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stability test before launching the negative two-phase flash. If the mixture is not found to be unstable for the test compositions during the stability test, it is simply labelled as liquid or vapour using the Li-correlation as described in the documentation. Only when the mixture is found to be unstable, is the negative two-phase flash launched.
CompositionalMultiphaseFluid
rst.