Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use stability test in flash #3206

Merged
merged 61 commits into from
Aug 26, 2024
Merged

Conversation

dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Jul 2, 2024

This PR adds a stability test before launching the negative two-phase flash. If the mixture is not found to be unstable for the test compositions during the stability test, it is simply labelled as liquid or vapour using the Li-correlation as described in the documentation. Only when the mixture is found to be unstable, is the negative two-phase flash launched.

  • The Li-correlation requires the critical volumes. This makes the critical volume an input for all the two-phase compositional models (not just the ones that use LBC viscosity).
  • The stability test is changed. Once a test composition is found that makes the TPD negative, the iterations are terminated even before reaching the stationary point.
  • A description of the flash procedure is added to the CompositionalMultiphaseFluid rst.
  • Some heuristics for single phase detection are removed from the flash.

@dkachuma dkachuma changed the title Use stability test in flash feature: Use stability test in flash Jul 18, 2024
@dkachuma dkachuma changed the title feature: Use stability test in flash feat: Use stability test in flash Jul 18, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 99.06542% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.36%. Comparing base (f6caac7) to head (10a55cd).
Report is 91 commits behind head on develop.

Files with missing lines Patch % Lines
...ompositional/models/NegativeTwoPhaseFlashModel.hpp 95.45% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3206      +/-   ##
===========================================
+ Coverage    56.01%   56.36%   +0.34%     
===========================================
  Files         1053     1056       +3     
  Lines        89115    89233     +118     
===========================================
+ Hits         49919    50294     +375     
+ Misses       39196    38939     -257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@paveltomin
Copy link
Contributor

review?

@dkachuma dkachuma requested a review from paveltomin August 10, 2024 04:52
@dkachuma dkachuma requested a review from joshua-white as a code owner August 12, 2024 21:29
@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: no rebaseline Does not require rebaseline labels Aug 13, 2024
@CusiniM CusiniM added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Aug 26, 2024
@CusiniM CusiniM merged commit a3e4a51 into develop Aug 26, 2024
22 checks passed
@CusiniM CusiniM deleted the feature/dkachuma/stability-flash branch August 26, 2024 18:07
@dkachuma dkachuma mentioned this pull request Aug 28, 2024
24 tasks
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants