Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add component selector for fluid models #3213

Merged
merged 18 commits into from
Jul 24, 2024
+579 −70

Merge branch 'develop' into refactor/dkachuma/fluid-component-combina…

cb97a03
Select commit
Loading
Failed to load commit list.
Merged

refactor: Add component selector for fluid models #3213

Merge branch 'develop' into refactor/dkachuma/fluid-component-combina…
cb97a03
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 19, 2024 in 0s

55.83% (+0.11%) compared to 18db014

View this Pull Request on Codecov

55.83% (+0.11%) compared to 18db014

Details

Codecov Report

Attention: Patch coverage is 71.68142% with 32 lines in your changes missing coverage. Please review.

Project coverage is 55.83%. Comparing base (18db014) to head (cb97a03).

Files Patch % Lines
...dFlow/ThermalCompositionalMultiphaseFVMKernels.hpp 0.00% 17 Missing ⚠️
...ow/IsothermalCompositionalMultiphaseFVMKernels.hpp 0.00% 14 Missing ⚠️
...uid/compositional/CompositionalMultiphaseFluid.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3213      +/-   ##
===========================================
+ Coverage    55.71%   55.83%   +0.11%     
===========================================
  Files         1041     1042       +1     
  Lines        88575    88652      +77     
===========================================
+ Hits         49353    49501     +148     
+ Misses       39222    39151      -71

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov