Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: co2-brine PPU with capillary pressure continuity #3229

Closed
wants to merge 9 commits into from
Closed

feat: co2-brine PPU with capillary pressure continuity #3229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
55761ee
initial setup for 2 phase PPU + interface condition flux
ryar9534 Jul 17, 2024
9b4fc35
Merge branch 'develop' into feature/co2Brine_capInterfaceConditions
ryar9534 Jul 22, 2024
01267d0
testing git
Ammara-14 Jul 31, 2024
e2b4389
another commit
Ammara-14 Jul 31, 2024
0605bba
Merge branch 'develop' into feature/co2Brine_capInterfaceConditions
Ammara-14 Jul 31, 2024
8ecf871
Added Total Flux Computation
Ammara-14 Aug 1, 2024
3433c24
Added initialization of local solver - it shows linking error
Ammara-14 Aug 2, 2024
bab3938
Added initialization of local solver and fixed linking error
Ammara-14 Aug 6, 2024
ea3c18e
Added accessor for globalCompDensity
ryar9534 Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/coreComponents/finiteVolume/FluxApproximationBase.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ enum class UpwindingScheme : integer
{
PPU, ///< PPU upwinding
C1PPU, ///< C1-PPU upwinding from https://doi.org/10.1016/j.advwatres.2017.07.028
IHU ///< IHU as in https://link.springer.com/content/pdf/10.1007/s10596-019-09835-6.pdf
IHU, ///< IHU as in https://link.springer.com/content/pdf/10.1007/s10596-019-09835-6.pdf
PPUIC
};

/**
Expand All @@ -48,7 +49,8 @@ enum class UpwindingScheme : integer
ENUM_STRINGS( UpwindingScheme,
"PPU",
"C1PPU",
"IHU" );
"IHU",
"PPUIC" );

/**
* @struct UpwindingParameters
Expand All @@ -57,7 +59,7 @@ ENUM_STRINGS( UpwindingScheme,
*/
struct UpwindingParameters
{
/// PPU or C1-PPU or IHU
/// PPU or C1-PPU or IHU or PPU+interface conditions
UpwindingScheme upwindingScheme;

/// C1-PPU smoothing tolerance
Expand Down
Loading
Loading