Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: stress_and_pressure_initialization #3249

Merged
merged 32 commits into from
Aug 14, 2024
Merged

Conversation

Oluwatobi-PM
Copy link
Contributor

@Oluwatobi-PM Oluwatobi-PM commented Jul 26, 2024

This changes contains the documentation on how to perform both a gravity-only and user defined initalization of the stresses in a simple reservoir model and then compare the calculated stresses with the analytical Eaton's equation/user-provided tables respectively.

@Oluwatobi-PM Oluwatobi-PM self-assigned this Jul 26, 2024
@Oluwatobi-PM Oluwatobi-PM changed the title simple_gravity_initialization docs: simple_gravity_initialization Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.99%. Comparing base (f3eb4dc) to head (88af3ad).
Report is 82 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3249   +/-   ##
========================================
  Coverage    55.99%   55.99%           
========================================
  Files         1053     1053           
  Lines        89157    89157           
========================================
  Hits         49921    49921           
  Misses       39236    39236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oluwatobi-PM Oluwatobi-PM changed the title docs: simple_gravity_initialization docs: stress_and_pressure_initialization Jul 26, 2024
@jhuang2601 jhuang2601 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 8, 2024
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Oluwatobi-PM for documenting these features!

@jhuang2601
Copy link
Contributor

Expected failure and rebaseline is required

=======================
Test failures
=======================
gravityInducedStress_initialization_smoke_01
gravityInducedStress_initialization_smoke_04
userdefinedStress_initialization_smoke_01
userdefinedStress_initialization_smoke_04
=======================
Overall status: FAILED
=======================

@jhuang2601 jhuang2601 added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Aug 8, 2024


#################################################################################
Model Initialization: Hydrostatic and Mechanical Equilibrium
Copy link
Collaborator

@CusiniM CusiniM Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of going under Basic Examples this needs its own section about Poromechanical models initialization and directly in the User Guide?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, create a dedicated section about initialization in the User Guide

Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I wonder if we should document this in the user guide instead of doing it through examples. We can also do this later on and add a discussion in the user guide and keep these examples to demonstrate what to do.

@rrsettgast rrsettgast merged commit c29c4ec into develop Aug 14, 2024
22 checks passed
@rrsettgast rrsettgast deleted the docs/raji/initialization branch August 14, 2024 17:12
rrsettgast added a commit that referenced this pull request Sep 17, 2024
* Updates to Gravity-Only Case

* User-defined Initialization Case

* Restructure examples into 2 folders

* update python scripts

* fix sphinx links

* update xml files and add smoke tests

* update rst file for gravity based model

* Clean Up Figures

---------

Co-authored-by: Oluwatobi Quadri Raji <[email protected]>
Co-authored-by: Jian HUANG <[email protected]>
Co-authored-by: Herve Gross <[email protected]>
Co-authored-by: Oluwatobi Quadri Raji <[email protected]>
Co-authored-by: Randolph Settgast <[email protected]>
rrsettgast added a commit that referenced this pull request Sep 17, 2024
* Updates to Gravity-Only Case

* User-defined Initialization Case

* Restructure examples into 2 folders

* update python scripts

* fix sphinx links

* update xml files and add smoke tests

* update rst file for gravity based model

* Clean Up Figures

---------

Co-authored-by: Oluwatobi Quadri Raji <[email protected]>
Co-authored-by: Jian HUANG <[email protected]>
Co-authored-by: Herve Gross <[email protected]>
Co-authored-by: Oluwatobi Quadri Raji <[email protected]>
Co-authored-by: Randolph Settgast <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants