Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove "using namespace" in header files #3255

Merged
merged 15 commits into from
Aug 12, 2024
Merged

refactor: Remove "using namespace" in header files #3255

merged 15 commits into from
Aug 12, 2024

Conversation

rrsettgast
Copy link
Member

We should NOT have using namespace in headers. There are some cases where it isn't dangerous, like if in a function scope....but other than that we disallow it.

@rrsettgast rrsettgast changed the title Remove "using namespace" in header files refactor: Remove "using namespace" in header files Jul 30, 2024
@rrsettgast rrsettgast marked this pull request as ready for review August 9, 2024 05:22
@rrsettgast rrsettgast requested a review from jhuang2601 as a code owner August 10, 2024 01:12
@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 10, 2024
@rrsettgast
Copy link
Member Author

@acitrain @corbett5 @sframba @wrtobin Please review.

@rrsettgast rrsettgast requested a review from cssherman as a code owner August 10, 2024 01:29
@codecov Codecov
Copy link

codecov bot commented Aug 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.74648% with 90 lines in your changes missing coverage. Please review.

Project coverage is 55.99%. Comparing base (b4b1a3a) to head (347bf63).
Report is 84 commits behind head on develop.

Files with missing lines Patch % Lines
...malSinglePhasePoromechanicsConformingFractures.hpp 0.00% 12 Missing ⚠️
...ermalSinglePhasePoromechanicsEmbeddedFractures.hpp 0.00% 12 Missing ⚠️
...ow/IsothermalCompositionalMultiphaseFVMKernels.hpp 40.00% 9 Missing ⚠️
...hysicsSolvers/multiphysics/PoromechanicsSolver.hpp 0.00% 7 Missing ⚠️
...ls/SinglePhasePoromechanicsConformingFractures.hpp 0.00% 7 Missing ⚠️
...nels/SinglePhasePoromechanicsEmbeddedFractures.hpp 0.00% 7 Missing ⚠️
...n/anisotropic/AcousticVTIWaveEquationSEMKernel.hpp 0.00% 7 Missing ⚠️
...Flow/ThermalCompositionalMultiphaseBaseKernels.hpp 25.00% 6 Missing ⚠️
...s/constitutive/fluid/multifluid/MultiFluidBase.hpp 81.48% 5 Missing ⚠️
...tive/relativePermeability/RelpermDriverRunTest.hpp 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3255      +/-   ##
===========================================
- Coverage    55.99%   55.99%   -0.01%     
===========================================
  Files         1053     1053              
  Lines        89157    89157              
===========================================
- Hits         49921    49919       -2     
- Misses       39236    39238       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rrsettgast rrsettgast force-pushed the cleanup/removeUsingNamespaceInHeaders branch from 8b9d9d8 to 5050597 Compare August 10, 2024 20:29
@rrsettgast rrsettgast merged commit 93b3a72 into develop Aug 12, 2024
22 checks passed
@rrsettgast rrsettgast deleted the cleanup/removeUsingNamespaceInHeaders branch August 12, 2024 20:22
rrsettgast added a commit that referenced this pull request Sep 17, 2024
@rrsettgast
refactor: Remove "using namespace" in header files (#3255)
1984702 
* remove using namespace dataRepository from headers files

* remove using namespace multifluid from NegativeTwoPhaseFlash.hpp

* removed using namespace constitutive from headers files

* removed using namespace fields from headers files

* removed using namespace stabilization from headers files

* removed using namespace fluxKernelsHelper from headers files

* remove using namespace surfaceGenerationKernelsHelpers from header files
rrsettgast added a commit that referenced this pull request Sep 17, 2024
@rrsettgast
refactor: Remove "using namespace" in header files (#3255)
8d01edf 
* remove using namespace dataRepository from headers files

* remove using namespace multifluid from NegativeTwoPhaseFlash.hpp

* removed using namespace constitutive from headers files

* removed using namespace fields from headers files

* removed using namespace stabilization from headers files

* removed using namespace fluxKernelsHelper from headers files

* remove using namespace surfaceGenerationKernelsHelpers from header files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sframba sframba sframba left review comments

@dkachuma dkachuma dkachuma approved these changes

@CusiniM CusiniM CusiniM approved these changes

@castelletto1 castelletto1 castelletto1 approved these changes

@untereiner untereiner untereiner approved these changes

@wrtobin wrtobin wrtobin approved these changes

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@acitrain acitrain Awaiting requested review from acitrain acitrain is a code owner

@paveltomin paveltomin Awaiting requested review from paveltomin paveltomin is a code owner

@klevzoff klevzoff Awaiting requested review from klevzoff

@francoishamon francoishamon Awaiting requested review from francoishamon

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner

@joshua-white joshua-white Awaiting requested review from joshua-white

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

Assignees

@rrsettgast rrsettgast

@CusiniM CusiniM

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rrsettgast @wrtobin @untereiner @sframba @castelletto1 @CusiniM @dkachuma