Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changing GEOSX to GEOS in external mesh import #3278

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

ryar9534
Copy link
Contributor

Fixing some remaining GEOSX usage to GEOS in external mesh imports.

@ryar9534 ryar9534 marked this pull request as ready for review August 12, 2024 17:22
@ryar9534 ryar9534 self-assigned this Aug 12, 2024
@ryar9534 ryar9534 added type: cleanup / refactor Non-functional change (NFC) flag: ready for review changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 12, 2024
Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.99%. Comparing base (93b3a72) to head (d5c339e).
Report is 84 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3278   +/-   ##
========================================
  Coverage    55.99%   55.99%           
========================================
  Files         1053     1053           
  Lines        89157    89157           
========================================
  Hits         49921    49921           
  Misses       39236    39236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryar9534 ryar9534 added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Aug 12, 2024
@ryar9534 ryar9534 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Aug 12, 2024
@rrsettgast rrsettgast merged commit f3eb4dc into develop Aug 13, 2024
22 checks passed
@rrsettgast rrsettgast deleted the chore/aronson/externalMeshGEOSXToGEOS branch August 13, 2024 16:57
MelReyCG added a commit that referenced this pull request Aug 20, 2024
MelReyCG added a commit that referenced this pull request Aug 20, 2024
MelReyCG added a commit that referenced this pull request Aug 20, 2024
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
* Changing GEOSX to GEOS in external mesh import

* Update .integrated_tests.yaml

* Update BASELINE_NOTES.md
rrsettgast pushed a commit that referenced this pull request Sep 17, 2024
* Changing GEOSX to GEOS in external mesh import

* Update .integrated_tests.yaml

* Update BASELINE_NOTES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes XML input ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants