-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Reuse computeSinglePhaseFlux #3283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3283 +/- ##
===========================================
+ Coverage 56.00% 56.02% +0.01%
===========================================
Files 1053 1053
Lines 89168 89123 -45
===========================================
- Hits 49935 49927 -8
+ Misses 39233 39196 -37 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
somehow requires rebaseline due to some numerical diffs, for example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this even different?
we should add a unitTest for this computeFlux function.
We should probably note somewhere to add the unit test, as if this gets merged I have a feeling we will forget |
src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseFVMKernels.hpp
Outdated
Show resolved
Hide resolved
@paveltomin @jhuang2601 @CusiniM |
|
issue is here #3297 i will merge it for now |
* Reuse computeSinglePhaseFlux * Update SinglePhaseFVMKernels.hpp
* Reuse computeSinglePhaseFlux * Update SinglePhaseFVMKernels.hpp
No description provided.