Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make the rock toughness scalable with the fracture size and test anisotropic toughness #3310

Merged
merged 15 commits into from
Jan 21, 2025

Conversation

frankfeifan
Copy link
Contributor

@frankfeifan frankfeifan commented Aug 28, 2024

This PR is to add and test features of rock toughness.

Scalable rock toughness

a new feature that makes the rock toughness scalable with the fracture size if the hydraulic fracture is very large. The underlying mechanism is that the cohesive region of rock fractures may scale up with the fracture size, thereby increasing the critical fracture energy and thus toughness. The specific formulation is

KIC = KIC_base*(1 + scalingFactor*sqrt(L)) where L is the distance to the fracture origin.

Here are the changes in this PR:

  • Change rockToughness to baseRockToughness, and add toughnessScalingFactor and fractureOrigin in SurfaceGenerator. fractureOrigin is manually input now, but can be removed later if we can find the fracture origin from the initial fracture geometry.
  • Plot K_IC by making it a field variable in fractureSubRegion,so that one can visualize the toughness in vtk.
  • Add a simple test to demonstrate the feature

Relevant references: Scholz, 2010, McClure, 2023

Anisotropic toughness

Existing hydrofracture solver has the capability to assign anisotropic toughness, but looks like there is no relevant test. An example is added to test this feature. Also, some changes may be needed to make this feature easier to use for users.

  • Add an example to test anisotropic rock toughness

@frankfeifan frankfeifan added changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 28, 2024
@frankfeifan frankfeifan self-assigned this Aug 28, 2024
@frankfeifan frankfeifan requested a review from cssherman as a code owner August 28, 2024 16:40
@frankfeifan frankfeifan changed the title Make the rock toughness scalable with the fracture size feature: Make the rock toughness scalable with the fracture size Aug 28, 2024
@frankfeifan frankfeifan changed the title feature: Make the rock toughness scalable with the fracture size feat: Make the rock toughness scalable with the fracture size Aug 28, 2024
@frankfeifan frankfeifan added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 56.87%. Comparing base (18e0c4e) to head (1eb3f94).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...sicsSolvers/surfaceGeneration/SurfaceGenerator.cpp 0.00% 35 Missing ⚠️
...sicsSolvers/surfaceGeneration/SurfaceGenerator.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3310      +/-   ##
===========================================
- Coverage    56.89%   56.87%   -0.02%     
===========================================
  Files         1157     1157              
  Lines       101214   101244      +30     
===========================================
  Hits         57582    57582              
- Misses       43632    43662      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfeifan frankfeifan added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Aug 29, 2024
@frankfeifan frankfeifan changed the title feat: Make the rock toughness scalable with the fracture size feat: Make the rock toughness scalable with the fracture size and test anisotropic toughness Sep 17, 2024
name="KIC_21"
initialCondition="1"
setNames="{ all }"
objectPath="ElementRegions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess the anisotropic KI will not affect the propagation direction (still perpendicular to the minimum principal stress) but the propagation speed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, correct. The fracture will remain in the same plane. It changes the propagation speed in the two directions though. It's quite useful to match field data.

Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to encapsulate everything related to the rock toughness into a constitutive model and completely remove the rockToughness as a parameter of the SurfaceGenerator. However, I am okay with merging this first and then introduce:

  • 1 a PR to create an appropriate constitutive model. I think the KIC computations could be moved into a costitutive model too.
  • 2 a PR to replace the current calculations with the new constitutive model.

@CusiniM
Copy link
Collaborator

CusiniM commented Jan 3, 2025

* [x]  Add an example to test anisotropic rock toughness

Adding a test is good but I would take the simple example we used in the FORGE report (with the idealized stress profile) an make an advanced example in readthedocs from it.

@rrsettgast
Copy link
Member

@frankfeifan Questions about adding a size based toughness modification:

  1. The toughness increases with increase in size, meaning it is harder to propagate the fracture for a homogeneous body as the size of the fracture grows. I am familiar with arguments based on field scale data, but is this behavior observed at lab scale samples for intact rock...or even some other material?
  2. Is this factor a way to account for plastic slip in the rock surrounding the fracture?
  3. For non-penny shaped fracture, are there observations that support different scaling factors in different orientations?

@frankfeifan
Copy link
Contributor Author

@frankfeifan Questions about adding a size based toughness modification:

  1. The toughness increases with increase in size, meaning it is harder to propagate the fracture for a homogeneous body as the size of the fracture grows. I am familiar with arguments based on field scale data, but is this behavior observed at lab scale samples for intact rock...or even some other material?
  2. Is this factor a way to account for plastic slip in the rock surrounding the fracture?
  3. For non-penny shaped fracture, are there observations that support different scaling factors in different orientations?

@rrsettgast Please find my replies below:

  1. I did some literature study. There are some lab observations about this scale dependence using various experimental methods (e.g., Brazilian test), although not in the context of hydraulic fracturing: https://link.springer.com/article/10.1007/s00603-021-02468-1, https://www.sciencedirect.com/science/article/pii/S1674775522002293#bib91 and references therein.

  2. It’s highly possible and the dissipation associated with plastic slip may be scaled with the fracture size. Actually, one explanation in literature is based on the fracture processing zone (FPZ) where micro-cracking and plastic deformation happen. Consider a cohesive zone model for this FPZ, the area bounded by the traction-crack opening curve is the critical fracture energy (Gc). Many field observations indicate that the opening/crack separation is proportional to the fracture size (L). If we consider the tensile strength keeps constant, then Gc is proportional to L, so K_Ic is proportional to sqrt(L).

  3. This is a good point. I didn't see relevant evidence unfortunately. In other HF models, they use a unique scaling factor for the entire fracture and calculate it using either the larger or smaller of the fracture length and height. IMO, if this apparent scale (size) dependence is due to FPZ at the front of the crack tip, then maybe it makes more sense to compute the scaling factor on each fracture cell at the tip individually (what we do now)?

Copy link
Member

@rrsettgast rrsettgast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a note to follow up on different methods for calculating the factor.

@frankfeifan frankfeifan added the ci: run code coverage enables running of the code coverage CI jobs label Jan 14, 2025
@CusiniM CusiniM requested a review from wrtobin as a code owner January 21, 2025 17:10
@CusiniM CusiniM merged commit 0ad432d into develop Jan 21, 2025
23 of 25 checks passed
@CusiniM CusiniM deleted the feat/frankfei/scalingToughness branch January 21, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants