Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable fully coupled mode for CompositionalMultiphaseReservoirPoromechanics and SinglePhaseReservoirPoromechanics #3388

Merged
merged 47 commits into from
Dec 14, 2024
Merged

feat: Enable fully coupled mode for CompositionalMultiphaseReservoirPoromechanics and SinglePhaseReservoirPoromechanics #3388

merged 47 commits into from
Dec 14, 2024

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Oct 4, 2024 •
edited
Loading

should go after #3422

  • works equivalent to MultiphasePoromechanicsReservoir and SinglePhasePoromechanicsReservoir, just more convenient to switch between FIM and SEQ within the same solver
  • can use the same MGR recipe (order of block is actually the same: mechanics, flow, wells)

@paveltomin paveltomin self-assigned this Oct 4, 2024
@paveltomin paveltomin changed the base branch from develop to pt/set-mgr-strategy October 4, 2024 22:15
@paveltomin
Copy link
Contributor Author

need review please

CusiniM
CusiniM requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I would strongly prefer getting rid of MultiphasePoromechanicsReservoir and SinglePhasePoromechanicsReservoir

@paveltomin
Copy link
Contributor Author

Actually I would strongly prefer getting rid of MultiphasePoromechanicsReservoir and SinglePhasePoromechanicsReservoir

One reason they can be useful is to perform an isolated well solve to precondition the nonlinear system, that's why I am hesitant to remove them

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Dec 12, 2024
Base automatically changed from pt/set-mgr-strategy to develop December 13, 2024 22:41
@paveltomin paveltomin merged commit 5ce6497 into develop Dec 14, 2024
25 checks passed
@paveltomin paveltomin deleted the pt/enable-fim branch December 14, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@victorapm victorapm victorapm approved these changes

@CusiniM CusiniM CusiniM approved these changes

@rasimHZ rasimHZ Awaiting requested review from rasimHZ

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@ryar9534 ryar9534 Awaiting requested review from ryar9534 ryar9534 is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren

Assignees

@paveltomin paveltomin

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paveltomin @CusiniM @victorapm @jhuang2601