-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: detangle and unify flow initialization, fix netToGross bug #3393
Conversation
porousSolid.scaleReferencePorosity( netToGross ); | ||
permeability.scaleHorizontalPermeability( netToGross ); | ||
|
||
// in some initializeState versions it uses newPorosity, so let's run updatePorosityAndPermeability to compute something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this double update is still confusing but i don't really want to touch the constitutives...
one case requires rebaseline:
the reason is a bug that appears here: GEOS/src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp Line 886 in e601fad
where compAmount does not include the effect of netToGross (don't ask me why).
The issue is addressed in this PR here
|
@CusiniM need your review |
@CusiniM please review |
@CusiniM, @castelletto1, @cssherman, @jhuang2601, @rrsettgast, and/or @wrtobin need your approval for rebaselines |
@CusiniM, @castelletto1, @cssherman, @jhuang2601, @rrsettgast, and/or @wrtobin still need your approval for rebaselines |
No description provided.