Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup setMGRStrategy a bit #3422

Merged
merged 28 commits into from
Dec 13, 2024

Merge branch 'develop' into pt/set-mgr-strategy

ba14408
Select commit
Loading
Failed to load commit list.
Merged

refactor: cleanup setMGRStrategy a bit #3422

Merge branch 'develop' into pt/set-mgr-strategy
ba14408
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 13, 2024 in 0s

56.84% (-0.06%) compared to b5ea7ce

View this Pull Request on Codecov

56.84% (-0.06%) compared to b5ea7ce

Details

Codecov Report

Attention: Patch coverage is 6.75676% with 138 lines in your changes missing coverage. Please review.

Project coverage is 56.84%. Comparing base (b5ea7ce) to head (ba14408).

Files with missing lines Patch % Lines
...sSolvers/multiphysics/SinglePhasePoromechanics.cpp 0.00% 17 Missing ⚠️
...vers/multiphysics/SinglePhaseReservoirAndWells.cpp 15.78% 16 Missing ⚠️
...csSolvers/multiphysics/MultiphasePoromechanics.cpp 0.00% 15 Missing ⚠️
...olvers/contact/SolidMechanicsEmbeddedFractures.cpp 0.00% 14 Missing ⚠️
...ysics/CompositionalMultiphaseReservoirAndWells.cpp 17.64% 14 Missing ⚠️
...sSolvers/contact/SolidMechanicsLagrangeContact.cpp 0.00% 13 Missing ⚠️
...hysicsSolvers/multiphysics/HydrofractureSolver.cpp 0.00% 10 Missing ⚠️
...cs/SinglePhasePoromechanicsConformingFractures.cpp 0.00% 9 Missing ⚠️
...sics/SinglePhasePoromechanicsEmbeddedFractures.cpp 0.00% 9 Missing ⚠️
...vers/multiphysics/CoupledReservoirAndWellsBase.hpp 44.44% 5 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3422      +/-   ##
===========================================
- Coverage    56.89%   56.84%   -0.06%     
===========================================
  Files         1154     1154              
  Lines        99878    99954      +76     
===========================================
- Hits         56828    56818      -10     
- Misses       43050    43136      +86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov