feat: Overall Composition (Z) Formulation #3443
Open
+4,234
−463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
reviewed
Nov 20, 2024
src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Nov 20, 2024
| MultiFluidBase const & fluid = getConstitutiveModel< MultiFluidBase >( dataGroup, fluidName ); | ||
|
|
||
| // For now: isothermal only | ||
| GEOS_ERROR_IF( m_isThermal, GEOS_FMT( "CompositionalMultiphaseBase {}: Z Formulation is currently not available for thermal simulations", getDataContext() ) ); |
There was a problem hiding this comment.
no need for CompositionalMultiphaseBase, I think getDataContext() should provide enough info
There was a problem hiding this comment.
and this check should be in postInputInitialization
paveltomin
reviewed
Nov 20, 2024
src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Nov 20, 2024
src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp
Show resolved
Hide resolved
paveltomin
reviewed
Nov 20, 2024
| { | ||
| typename TYPEOFREF( stencil ) ::KernelWrapper stencilWrapper = stencil.createKernelWrapper(); | ||
|
|
||
| GEOS_ERROR_IF( m_isThermal, GEOS_FMT( |
There was a problem hiding this comment.
move checks somewhere earlier
paveltomin
reviewed
Nov 20, 2024
src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseFVM.cpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Nov 20, 2024
...ysicsSolvers/fluidFlow/kernels/compositional/zFormulation/AccumulationZFormulationKernel.hpp
Outdated
Show resolved
Hide resolved
paveltomin
reviewed
Nov 20, 2024
...mponents/physicsSolvers/fluidFlow/kernels/compositional/zFormulation/PotGradZFormulation.hpp
Outdated
Show resolved
Hide resolved
added 2 commits
November 21, 2024 10:17
added 2 commits
December 18, 2024 09:39
paveltomin
added
the
ci: run integrated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary implementation. Validated in immiscible case.