feat: MpiWrapper::allReduce overload for arrays. #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
requested review from
rrsettgast,
MelReyCG,
corbett5 and
wrtobin
as code owners
CusiniM
commented
Nov 15, 2024
CusiniM
commented
Nov 15, 2024
…OS-DEV/GEOS into feature/cusini/addMpiWrapperForArrays
|
@rrsettgast , @corbett5 , @wrtobin this is ready for review. |
rrsettgast
approved these changes
Dec 5, 2024
Comment on lines
+26
to
+65
| namespace geos | ||
| { | ||
|
|
||
| namespace internal | ||
| { | ||
|
|
||
| template< typename T, typename = void > | ||
| struct has_value_type : std::false_type {}; | ||
|
|
||
| template< typename T > | ||
| struct has_value_type< T, std::void_t< typename T::value_type > > : std::true_type {}; | ||
|
|
||
| template< typename T, typename = void > | ||
| struct has_ValueType : std::false_type {}; | ||
|
|
||
| template< typename T > | ||
| struct has_ValueType< T, std::void_t< typename T::ValueType > > : std::true_type {}; | ||
|
|
||
| } // namespace internal | ||
|
|
||
| template< typename T, typename Enable = void > | ||
| struct get_value_type | ||
| { | ||
| static_assert( sizeof(T) == 0, "T must define either value_type or ValueType." ); | ||
| }; | ||
|
|
||
| template< typename T > | ||
| struct get_value_type< T, std::enable_if_t< internal::has_value_type< T >::value > > | ||
| { | ||
| using type = typename T::value_type; | ||
| }; | ||
|
|
||
| template< typename T > | ||
| struct get_value_type< T, std::enable_if_t< !internal::has_value_type< T >::value && internal::has_ValueType< T >::value > > | ||
| { | ||
| using type = typename T::ValueType; | ||
| }; | ||
|
|
||
| } // namespace geos | ||
|
|
MelReyCG
reviewed
Dec 5, 2024
There was a problem hiding this comment.
At this point, can we drop or at least set to private the following signature?
template< typename T >
static int allReduce( T const * sendbuf, T * recvbuf, int count, MPI_Op op, MPI_Comm comm = MPI_COMM_GEOS );
All external calls seem to be able to be translated to Span<T[]>.
yes, you are right, let me try to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug because two arrays of different size were exchanged by grabbing the buffers directly. This overload will prevent it from happening.
I had to add a small helper coz
LvArrayhasValueTypeinstead ofvalue_typelikestdobjects.