Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rate-and-state friction with explicit time integration #3450

Merged
merged 65 commits into from
Dec 10, 2024

Conversation

VidarStiernstrom
Copy link
Contributor

Adds rate-and-state friction kernels based on explicit time integration of the rate-and-state equations. Adds a quasi-dynamic solver with an embedded (adaptive) Runge-Kutta 3(2) method for rate/state.

@CusiniM CusiniM assigned VidarStiernstrom and unassigned CusiniM Dec 6, 2024
@CusiniM CusiniM added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 6, 2024
@@ -74,6 +74,14 @@ DECLARE_FIELD( dispJump,
WRITE_AND_READ,
"Displacement jump vector in the local reference system" );

DECLARE_FIELD( dispJump_n,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should get rid of old at some point though.

Copy link
Collaborator

@CusiniM CusiniM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start. You should run make uncrustify_style to fix the formatting.

I have created an issue to keep track of things that need to be improved.

#3482

@VidarStiernstrom VidarStiernstrom added ci: run CUDA builds Allows to triggers (costly) CUDA jobs and removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs labels Dec 6, 2024
@CusiniM CusiniM added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Dec 7, 2024
@VidarStiernstrom VidarStiernstrom added the ci: run code coverage enables running of the code coverage CI jobs label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0.26316% with 379 lines in your changes missing coverage. Please review.

Project coverage is 56.89%. Comparing base (eef8de4) to head (f861184).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...csSolvers/inducedSeismicity/QuasiDynamicEQRK32.cpp 0.00% 231 Missing ⚠️
.../inducedSeismicity/kernels/RateAndStateKernels.hpp 0.00% 110 Missing ⚠️
...csSolvers/inducedSeismicity/QuasiDynamicEQRK32.hpp 3.70% 26 Missing ⚠️
...csSolvers/inducedSeismicity/rateAndStateFields.hpp 0.00% 5 Missing ⚠️
...hysicsSolvers/inducedSeismicity/QuasiDynamicEQ.cpp 0.00% 4 Missing ⚠️
...omponents/physicsSolvers/contact/ContactFields.hpp 0.00% 2 Missing ⚠️
...hysicsSolvers/inducedSeismicity/QuasiDynamicEQ.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3450      +/-   ##
===========================================
- Coverage    57.09%   56.89%   -0.21%     
===========================================
  Files         1152     1154       +2     
  Lines        99520    99885     +365     
===========================================
+ Hits         56824    56825       +1     
- Misses       42696    43060     +364     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CusiniM CusiniM merged commit 7e2c33b into develop Dec 10, 2024
23 of 25 checks passed
@CusiniM CusiniM deleted the feature/cstierns/rate-and-state-explicit branch December 10, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants