test: Add unit tests for RTType.hpp #3452
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
reviewed
Nov 19, 2024
Comment on lines
79
to
80
| m_node(), | ||
| m_group( "root", m_node ), |
There was a problem hiding this comment.
I guess the wrapper constructor nees a group... But what's the conduit node for?
There was a problem hiding this comment.
ah... you need to make a Group.. okay I was hoping we could avoid that include.
…EOS-DEV/GEOS into test/omarduran/unitest_rttypes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3452 +/- ##
===========================================
+ Coverage 56.82% 56.83% +0.01%
===========================================
Files 1154 1158 +4
Lines 99984 100016 +32
===========================================
+ Hits 56816 56848 +32
Misses 43168 43168 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces unit test for
RTTypes.hpp. The motivation is to test a failing dynamic cast with reference in apple clang 16.0.0 whenNEW_TYPE==EXISTING_TYPE(see NEW_TYPE dynamicCast( EXISTING_TYPE & val )).Other functions and structures are being tested
RTTypes.hppto augment the test coverage.