Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/byer3/well dt #3473

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Feature/byer3/well dt #3473

merged 3 commits into from
Dec 3, 2024

Conversation

tjb-ltk
Copy link
Contributor

@tjb-ltk tjb-ltk commented Dec 3, 2024

  1. Initialize well if previously shut-in when t> 0, well is always initialized at t=0
  2. Re-introduce Jacobian shutin-logic for singlephase wells, inadvertently removed by thermal well dev(in some cases added few more Newtons at timestep when well goes from open to shut)

@tjb-ltk
Always initialize well if previously closed
fa91c83
@tjb-ltk
re-introduce Jacobian shutin-logic for singlephase wells, inadverntly…
4a7868e 
… removed by thermal well dev(in some cases added few more Newtons at timestep when well goes from open to shut)
@paveltomin paveltomin merged commit e3e0f10 into pt/well-dt Dec 3, 2024
10 of 13 checks passed
@paveltomin paveltomin deleted the feature/byer3/well-dt branch December 3, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@paveltomin paveltomin Awaiting requested review from paveltomin paveltomin is a code owner

@ryar9534 ryar9534 Awaiting requested review from ryar9534 ryar9534 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjb-ltk @paveltomin