Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Trilinos. #3475

Merged
merged 12 commits into from
Dec 11, 2024
Merged

chore: upgrade Trilinos. #3475

merged 12 commits into from
Dec 11, 2024

Conversation

CusiniM
Copy link
Collaborator

@CusiniM CusiniM commented Dec 4, 2024

@CusiniM CusiniM self-assigned this Dec 4, 2024
@rrsettgast rrsettgast marked this pull request as ready for review December 5, 2024 01:13
@rrsettgast rrsettgast self-requested a review as a code owner December 5, 2024 01:13
@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Dec 5, 2024
@rrsettgast
Copy link
Member

rrsettgast commented Dec 5, 2024

@CusiniM I approved it, but we do need to build the TPL's on LC and update the tag. Let me know if you can do it or if you need me to help.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.88%. Comparing base (651c600) to head (c9ae464).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3475   +/-   ##
========================================
  Coverage    56.88%   56.88%           
========================================
  Files         1154     1154           
  Lines        99885    99885           
========================================
  Hits         56823    56823           
  Misses       43062    43062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CusiniM
Copy link
Collaborator Author

CusiniM commented Dec 5, 2024

@CusiniM I approved it, but we do need to build the TPL's on LC and update the tag. Let me know if you can do it or if you need me to help.

yeah, I ll take care of it.

@CusiniM CusiniM merged commit 6cc493e into develop Dec 11, 2024
25 checks passed
@CusiniM CusiniM deleted the chore/cusini/upgradeTrilinos branch December 11, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants