Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IO timers #3480

Merged
merged 9 commits into from
Dec 7, 2024
Merged

feat: IO timers #3480

merged 9 commits into from
Dec 7, 2024

Conversation

victorapm
Copy link
Contributor

@victorapm victorapm commented Dec 6, 2024

Add timing statistics for output file writing. Can be turned on with logLevel >= 1

Useful for SPE11 tests and benchmarks in general.

@victorapm victorapm self-assigned this Dec 6, 2024
@victorapm victorapm changed the title IO timers feat: IO timers Dec 6, 2024
@victorapm victorapm added flag: ready for review ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 4.85437% with 98 lines in your changes missing coverage. Please review.

Project coverage is 57.09%. Comparing base (be0eb0e) to head (01a009f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../coreComponents/fileIO/Outputs/BlueprintOutput.cpp 0.00% 28 Missing ⚠️
src/coreComponents/fileIO/Outputs/SiloOutput.cpp 0.00% 25 Missing ⚠️
src/coreComponents/fileIO/Outputs/VTKOutput.cpp 7.14% 13 Missing ⚠️
...rc/coreComponents/fileIO/Outputs/RestartOutput.cpp 0.00% 10 Missing ⚠️
...oreComponents/fileIO/Outputs/TimeHistoryOutput.cpp 0.00% 8 Missing ⚠️
src/coreComponents/fileIO/Outputs/OutputBase.cpp 22.22% 7 Missing ⚠️
src/coreComponents/fileIO/Outputs/ChomboIO.cpp 0.00% 3 Missing ⚠️
src/coreComponents/fileIO/Outputs/PythonOutput.cpp 0.00% 3 Missing ⚠️
src/coreComponents/fileIO/Outputs/VTKOutput.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3480      +/-   ##
===========================================
- Coverage    57.11%   57.09%   -0.03%     
===========================================
  Files         1151     1152       +1     
  Lines        99475    99520      +45     
===========================================
+ Hits         56818    56822       +4     
- Misses       42657    42698      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorapm victorapm added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Dec 6, 2024
@victorapm
Copy link
Contributor Author

Rebaseline required due to new parameter:

  ********************************************************************************
  Error: /Problem/Outputs/siloOutput
  	Group has a child 'logLevel' in the file to compare but not the baseline file.
  ********************************************************************************
  ********************************************************************************
  Error: /Problem/Outputs/restartOutput
  	Group has a child 'logLevel' in the file to compare but not the baseline file.
  ********************************************************************************
  ********************************************************************************
  Error: /Problem/Outputs/siloOutput
  	Group has a child 'logLevel' in the file to compare but not the baseline file.
  ********************************************************************************
  ********************************************************************************
  Error: /Problem/Outputs/restartOutput
  	Group has a child 'logLevel' in the file to compare but not the baseline file.
  ********************************************************************************
  ********************************************************************************
  Error: /Problem/Outputs/restartOutput
  	Group has a child 'logLevel' in the file to compare but not the baseline file.
  ********************************************************************************
  ********************************************************************************
  Error: /Problem/Outputs/siloOutput
  	Group has a child 'logLevel' in the file to compare but not the baseline file.
  ********************************************************************************

@paveltomin paveltomin merged commit eef8de4 into develop Dec 7, 2024
23 of 25 checks passed
@paveltomin paveltomin deleted the feature/paludettomag1/io-timers branch December 7, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants