Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clarify new gravity, clean up kernel flags usage, move CFL computations to FVM solver #3486

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Dec 9, 2024

  • clarify new gravity as requested here fix: make new gravity treatment from #3337 an option #3467 (comment)
  • clean up kernel flags usage in flow solver to avoid bugs: the basic idea is to set the flags outside of kernels create and launch to avoid mismatch between different version (isothermal/thermal etc) when one flag is set here but is missing there
  • move CFL computations to FVM solver where it belongs

@paveltomin paveltomin requested a review from rrsettgast December 9, 2024 00:04
@rrsettgast
Copy link
Member

@paveltomin Yes. this is what i meant. Could you:

  1. add more detail in the description and explain the options a bit
  2. think about adding a more detailed description in the documentation

@paveltomin paveltomin marked this pull request as ready for review December 9, 2024 16:59
@paveltomin paveltomin self-assigned this Dec 9, 2024
@paveltomin paveltomin added flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 9, 2024
@paveltomin
Copy link
Contributor Author

@paveltomin Yes. this is what i meant. Could you:

  1. add more detail in the description and explain the options a bit
  2. think about adding a more detailed description in the documentation

done, please have a look

@paveltomin paveltomin added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 9, 2024
@paveltomin
Copy link
Contributor Author

new rebaselines needed:

********************************************************************************
Error: /Problem/Solvers/compflow
	Group has a child 'useNewGravity' in the baseline file but not the file to compare.
********************************************************************************
********************************************************************************
Error: /Problem/Solvers/compflow
	Group has a child 'gravityDensityScheme' in the file to compare but not the baseline file.
********************************************************************************

@paveltomin
Copy link
Contributor Author

@rrsettgast is it good enough?

@paveltomin paveltomin changed the title refactor: clarify new gravity refactor: clarify new gravity, clean up kernel flags usage in flow solver to avoid bugs, move CFL computations to FVM solver Dec 20, 2024
@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Dec 20, 2024
@paveltomin paveltomin changed the title refactor: clarify new gravity, clean up kernel flags usage in flow solver to avoid bugs, move CFL computations to FVM solver refactor: clarify new gravity, clean up kernel flags usage, move CFL computations to FVM solver Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants