-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change Total S.A. to TotalEnergies #3487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
* Copyright (c) 2018-2024 Lawrence Livermore National Security LLC | ||
* Copyright (c) 2018-2024 The Board of Trustees of the Leland Stanford Junior University | ||
* Copyright (c) 2018-2024 TotalEnergies | ||
* Copyright (c) 2019- GEOS/GEOSX Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious - why this header is different across the files?
there is Chevron in the file below and above but not here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably because someone created a file in a PR using the old header, then when I changed the header, they didn't update their copy, then it was merged into develop, then that header was copied.....or I just messed up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paveltomin This should be fixed. If you happen to see anything else while you are randomly reviewing the 2000 files let me know 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I am wondering, any reason not to use the spdx identifier for copyright ? Like the one for licensing.
For example SPDX-FileCopyrightText: 2018-2024 TotalEnergies
Never really considered it. No reasons I can think of besides that it is ugly. What are the reasons to include the identifier? Is it not already obvious what the copyright is from the current header? |
Example for Base.hpp /*
* ------------------------------------------------------------------------------------------------------------
* SPDX-License-Identifier: LGPL-2.1-only
*
* Copyright (c) 2016-2024 Lawrence Livermore National Security LLC
* Copyright (c) 2018-2024 TotalEnergies
* Copyright (c) 2018-2024 The Board of Trustees of the Leland Stanford Junior University
* Copyright (c) 2023-2024 Chevron
* Copyright (c) 2019- GEOS/GEOSX Contributors
*
* See top level LICENSE, COPYRIGHT, CONTRIBUTORS, NOTICE, and ACKNOWLEDGEMENTS files for details.
* ------------------------------------------------------------------------------------------------------------
*/ After the change /*
* ------------------------------------------------------------------------------------------------------------
* SPDX-License-Identifier: LGPL-2.1-only
* SPDX-FileCopyrightText: (c) 2016-2024 Lawrence Livermore National Security LLC
* SPDX-FileCopyrightText: (c) 2018-2024 TotalEnergies
* SPDX-FileCopyrightText: (c) 2018-2024 The Board of Trustees of the Leland Stanford Junior University
* SPDX-FileCopyrightText: (c) 2023-2024 Chevron
* SPDX-FileCopyrightText: (c) 2019- GEOS/GEOSX Contributors
*
* See top level LICENSE, COPYRIGHT, CONTRIBUTORS, NOTICE, and ACKNOWLEDGEMENTS files for details.
* ------------------------------------------------------------------------------------------------------------
*/
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3487 +/- ##
===========================================
- Coverage 56.89% 56.88% -0.01%
===========================================
Files 1154 1154
Lines 99885 99885
===========================================
- Hits 56825 56823 -2
- Misses 43060 43062 +2 ☔ View full report in Codecov by Sentry. |
This PR fixes some copyright issues. since it touches so many files, I will bypass branch protections once @herve-gross approves.
GEOS-DEV/PVTPackage#52