Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove setNextDt from SolidMechanicsLagrangeContact #3490

Merged
merged 5 commits into from
Dec 15, 2024
Merged

fix: remove setNextDt from SolidMechanicsLagrangeContact #3490

merged 5 commits into from
Dec 15, 2024

Conversation

paveltomin
Copy link
Contributor

No description provided.

@paveltomin paveltomin added type: bug Something isn't working flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 12, 2024
@paveltomin paveltomin self-assigned this Dec 12, 2024
@paveltomin paveltomin mentioned this pull request Dec 12, 2024
Open
@paveltomin
Copy link
Contributor Author

rebaseline needed but no real results change, only this:

********************************************************************************
Error: /Problem/Solvers/lagrangiancontact/initialDt/__values__
	Scalar values of types float64 and float64 differ: 2.0, 1.0.
********************************************************************************

@paveltomin paveltomin added ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs and removed flag: ready for review labels Dec 12, 2024
@paveltomin paveltomin added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Dec 13, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@5ce6497). Learn more about missing BASE report.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #3490   +/-   ##
==========================================
  Coverage           ?   56.82%           
==========================================
  Files              ?     1154           
  Lines              ?    99984           
  Branches           ?        0           
==========================================
  Hits               ?    56818           
  Misses             ?    43166           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin merged commit bc41885 into develop Dec 15, 2024
25 checks passed
@paveltomin paveltomin deleted the pt/remove-setNextDt branch December 15, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guotong-Ren Guotong-Ren Guotong-Ren approved these changes

@CusiniM CusiniM CusiniM approved these changes

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

Assignees

@paveltomin paveltomin

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paveltomin @CusiniM @Guotong-Ren